From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Thu, 5 Mar 2020 00:07:45 +0200 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="109747"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 04 23:08:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9cBa-000STJ-Gu for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Mar 2020 23:08:14 +0100 Original-Received: from localhost ([::1]:40368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9cBZ-0003Bv-Fh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Mar 2020 17:08:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58800) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9cBP-0003B6-KP for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 17:08:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9cBO-0001nK-LR for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 17:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35960) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9cBO-0001nG-GC for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 17:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9cBO-0001Kt-BV for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 17:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Mar 2020 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15833596755060 (code B ref 38992); Wed, 04 Mar 2020 22:08:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 4 Mar 2020 22:07:55 +0000 Original-Received: from localhost ([127.0.0.1]:41933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9cBH-0001JV-9v for submit@debbugs.gnu.org; Wed, 04 Mar 2020 17:07:55 -0500 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:55973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9cBF-0001I0-Bm for 38992@debbugs.gnu.org; Wed, 04 Mar 2020 17:07:54 -0500 Original-Received: by mail-wm1-f44.google.com with SMTP id 6so3996325wmi.5 for <38992@debbugs.gnu.org>; Wed, 04 Mar 2020 14:07:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7C1oHNtoReIl2FfiP2lF/4KZzxQeh769wV7B+e5nmNs=; b=K6mPfGKq16AbNwqu/XqGdGk7mhO/jHFy4iRFn4IGR/UczbezcUfqPldXi57xgQpPNh snIWtr+v6293fPNT5fzgNkIgRuErvmJy/y1zyFKyKTR56y0GaYuJACgacULJtzMoqR3h SNHvC/Ddb1EBfb6AzunQ2UijWCo9z4o6FYveODlhb/63GIAcXbfKm9KT9gnBERNCSrBF l+od5xKcp3EgrgjnyZwsWUaynplmY4YPAWNxkD2TfAGTkY5efOZuO2C43HTUx7C6nOFv YjmTJPSIPMtRPun1JqSH1+99t8dvsFRPl9pEMdcNnLnbNGIp7zhk3R2QuFxgUmNUoapg qU8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7C1oHNtoReIl2FfiP2lF/4KZzxQeh769wV7B+e5nmNs=; b=GNkQZ7zWDzNDbBLx6XamVZRwWoJ9sBFMi0HEkoHtQ5eYghzZ3sNw2+/XccC0EzzN+Z wy4MMHx3tRJaubHLMMuRhx9miIr4Dpw4/iGwdsDGOU5fAm+kXMUPkgJHmcvqvdo9pCcn 0yuCh/JJobUOuF+TxZR/6ObnsyIROF0BtqM3y93/1ET64odhrZD2F0hOHmy6D7rQB1y/ gK94wzqYxHTZPv9ZUbypAm3xnLJ50wTzJoedE8ysK1t4vSqWLy/T3O4VTlZNqnWYAHTv CVO5hX8kU+6xAcKCNBEq3i0e68Yr5hwhqZKEFn0nqvT9iHoIUYpt1OYcHep/hky+6JJc wfFA== X-Gm-Message-State: ANhLgQ0+ekXBlo+OScMyYFm8LU+7NVinMTzifrTCYsV39prhXfIWSWtq Wh9lqWr8AJbp4eRaPbazThc= X-Google-Smtp-Source: ADFU+vsqv5gNnX7oe38iHi+xqCbEW7Kky+p+yqK2YlVk0tsWioDLdvK+vylBSBtHfVsUw8gozxCKjQ== X-Received: by 2002:a1c:4681:: with SMTP id t123mr5655001wma.86.1583359667560; Wed, 04 Mar 2020 14:07:47 -0800 (PST) Original-Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id t187sm6517902wmt.25.2020.03.04.14.07.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2020 14:07:46 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176861 Archived-At: On 05.02.2020 20:12, João Távora wrote: > Not exactly. There have been several issues discussed in this report, > and it's really a problem that the user can't easily input something > that completing-read would allow. > > > So isn't that a UI deficiency in fido-mode?  Mind you I'm calling it > a deficiency because it can't by definition be a bug.  fido-mode is a new > thing and I _made_ the spec for it.  Of course, I like your suggestions > for improvement (as I have showed here). It's a bug because it changes icomplete-mode in a way that makes completing-read fail its contract (which is to demand matching input when require-match is non-nil) in certain situations. That, in turn, will create problems in code that calls completing-read and relies on it fulfilling its contract. > > Maybe, Dmitry, we could revert to the earlier proposal with the new > > variable and somehow deprecate/discourage use of the one you're > > trying to change?  That should be safe and bring all the benefits of > > your change, right? > > Yes, we can do that. I'll make the new variable private, so we can rid > of it quickly on master. > > > Great!   Disregard the previous discussion if you want, just do this, > and move on. Yup.