From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Thu, 26 Oct 2023 03:27:13 +0300 Message-ID: References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> <87leeuvtft.fsf@gmail.com> <87edi6reyf.fsf@gmail.com> <87jzryg370.fsf@gmail.com> <871qe6wxle.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26339"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Basil Contovounesios , 64275-done@debbugs.gnu.org To: Wilhelm Kirschbaum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 26 02:40:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvoPn-0006bB-C2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Oct 2023 02:40:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvoDm-0005tN-NK; Wed, 25 Oct 2023 20:27:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvoDk-0005mb-29 for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 20:27:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvoDj-0002IX-Pn for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 20:27:31 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvoED-0003YN-VC for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 20:28:01 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Oct 2023 00:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 64275@debbugs.gnu.org, dmitry@gutov.dev, wkirschbaum@gmail.com Original-Received: via spool by 64275-done@debbugs.gnu.org id=D64275.169828007713647 (code D ref 64275); Thu, 26 Oct 2023 00:28:01 +0000 Original-Received: (at 64275-done) by debbugs.gnu.org; 26 Oct 2023 00:27:57 +0000 Original-Received: from localhost ([127.0.0.1]:60272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvoE9-0003Y1-C5 for submit@debbugs.gnu.org; Wed, 25 Oct 2023 20:27:57 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvoE4-0003Xl-Hv for 64275-done@debbugs.gnu.org; Wed, 25 Oct 2023 20:27:55 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8CC075C01EC; Wed, 25 Oct 2023 20:27:16 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 25 Oct 2023 20:27:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1698280036; x=1698366436; bh=w9V0uSx78ggdKO0bL0LDPehxPcS8pA6vC78 vAR/4xec=; b=SqsJb0hFsKwgfo8TMW4z1K8pUotq4l9JmkrfGcYQj2HDtzYc25q iaOLNw8qMPKa0KMBp/YNzsGw+D9ne8BoMq4hZ0g6lvpAIpx14s6D6FoPgkBANGgW ouI1lP85JnIL5p6pWSMWORdGcvOlX8E8xQxwqKhF1329/Y9RWQU7UzF6FqZz9rno oPk+ZrZYdfkaIRA5j7GZMohJNJrZIm01dHHGjljW1RVg+8wMwJzl9Ylx/PHglI3S dCsp7zswesDcAKJ7SpC4pTUaKNBwCiMdLdB0aeVJiVk6K3FppFk9cT10g//NDL3l GocL0Cbl5wN7EygNC5c0jc5zLmO0OVVSosw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698280036; x=1698366436; bh=w9V0uSx78ggdKO0bL0LDPehxPcS8pA6vC78 vAR/4xec=; b=ckEqNP4ICqz1uIjROhRZfdYkxMkw38x3cBVoRMFycPYPOWZPqz6 me2I0iCXWkDYf3jCCVi2RJSaU54ycHeozsn2ddBpk8qu+luho+PMby5R6GdNEeyd CeHI60Q0V/HuL0tQwAz3dYXnUC26HgL4LmVwFobI/83yhbWICvAf90KxD+fam3j0 NyF6AM1c+SAgzs5FpEf/J+s2PUzI2uaocCrNmBYKQd7MzaIQqz5/LGSuvJouG/Q1 g6+9KhQoYh71qbv1r2zldTRF6qnDioMu41mZ6cHSNCo1DdKIfBPyxTfznuvFYUwq g9pGSd8cRCD315x6P7gO7mgr4Z4+hbzXSdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledugdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffgfeej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Oct 2023 20:27:15 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273225 Archived-At: On 21/10/2023 10:39, Wilhelm Kirschbaum wrote: > > >>> > >>> I'm not sure what you meant by the last sentence, sorry. What > >>> do > >>> you > >>> think about the below? > >>> > >>>   (sigil (sigil_name) @elixir-ts-font-sigil-name-face) > >>>   @font-lock-string-face) > >> > >> Sorry for the late reply.  I believe the following patch is > >> more > >> appropriate as it will apply the sigil font to the entire > >> sigil, but > >> also respect the regex face.  We can add string specific > >> matches > >> later, > >> but happy just to simplify what we have and fix apply > >> appropriate > >> font > >> to previously unmatched sigils. > >> > >> [2. text/x-patch; > >> 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch]... > > > > Actually, the above patch breaks the embedded HEEx sigils' > > font. We > > have to exclude it when doing a general match.  Attached works > > with ~H > > sigils as well.  Please ignore the previous patch and install > > this > > one. > > > > [2. text/x-patch; > > 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode(1).patch]... > > > Sorry :(. I am finding more edge cases.  Maybe let me test it this > properly this week before we make any changes. > > > I tested this patch for a while now and it looks like the best approach > for handling regex sigils, but with an appropriate fallback. > > If this can be installed, it will be appreciated. Thanks! Installed, and closing.