From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20461: 25.0.50; `use-hard-newlines' Date: Thu, 23 Jan 2020 08:54:43 -0800 (PST) Message-ID: References: <129f4914-4719-44f6-b5ab-9e2d9586a790@default> <87wpnediqv.fsf@gnus.org> <87h80mix9t.fsf@marxist.se> <875zh2s6hf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="34316"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 20461@debbugs.gnu.org To: Lars Ingebrigtsen , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 23 20:51:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuiVQ-0008rZ-Ce for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Jan 2020 20:51:08 +0100 Original-Received: from localhost ([::1]:60648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuiVP-0005CZ-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Jan 2020 14:51:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44288) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iufl5-0004UO-Hy for bug-gnu-emacs@gnu.org; Thu, 23 Jan 2020 11:55:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iufl0-0004mF-LK for bug-gnu-emacs@gnu.org; Thu, 23 Jan 2020 11:55:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47136) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iufl0-0004mA-Gr for bug-gnu-emacs@gnu.org; Thu, 23 Jan 2020 11:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iufkz-0005Qd-Ld for bug-gnu-emacs@gnu.org; Thu, 23 Jan 2020 11:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2020 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 20461-submit@debbugs.gnu.org id=B20461.157979849420851 (code B ref 20461); Thu, 23 Jan 2020 16:55:01 +0000 Original-Received: (at 20461) by debbugs.gnu.org; 23 Jan 2020 16:54:54 +0000 Original-Received: from localhost ([127.0.0.1]:53109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iufks-0005QE-EW for submit@debbugs.gnu.org; Thu, 23 Jan 2020 11:54:54 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:44030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iufkq-0005Q2-QR for 20461@debbugs.gnu.org; Thu, 23 Jan 2020 11:54:53 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00NGd5jD047525; Thu, 23 Jan 2020 16:54:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=vYBv+nM1sLZ44Q65UcKTRzM/vKFIN42tK5rK9ChwJNY=; b=HVoNQONTVkj+k/6IIz4/JNJtHHFvUmLk5Q60H4lf/9h0unrvemi1a3RNMnddte7Tx4UD 6O4a93iH2jWrG0Na0p8p3GOt3t4v/3H9H1K4dgY86czNkjH/NaskxxfjHaAyFoHGGhIQ rgeZP/CbAve5BWdoRHB96A2URLg9whW5Ab6Oa+9bK6UL9usuKcranAIuvNaHLuo2qW2v 3yjOi0UM5GeruwQQ5LkxW2Ao0D4WywmVJ9UcQnvWmYklIt2tJs5A09Jg+A0YRMK+9oHz kwAXtTHSMVTDJEERJ9RwvSguaTCMv4pReeLuZYvxMSMQ/l6HlCyTuozmBWc/648RUfv+ Zg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2xkseuur52-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Jan 2020 16:54:46 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00NGcM2Q036378; Thu, 23 Jan 2020 16:54:46 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2xpq0wwmre-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Jan 2020 16:54:45 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 00NGsii9012097; Thu, 23 Jan 2020 16:54:44 GMT In-Reply-To: <875zh2s6hf.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4954.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9509 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=420 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001230132 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9509 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=483 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001230132 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175182 Archived-At: > I had another peek at this, and use-hard-newlines is slightly unusual > in that many functions bind the use-hard-newlines (and use it), like: >=20 > (defun fill-flowed-encode (&optional buffer) [...] > (when use-hard-newlines >=20 > So we'd presumably need to rename the variable, too, Yes, of course. That's true of any minor mode. Often people do not use the variable, but they certainly can, in general. > and then it just seems like it's not worth it, really. Why? No reason given. The right thing to do, to respect Emacs convention and not mislead users further, is to fix this. And yes, of course, that means also renaming the variable. This is trivial to fix.