unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, Stefan Kangas <stefan@marxist.se>
Cc: 20461@debbugs.gnu.org
Subject: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 08:54:43 -0800 (PST)	[thread overview]
Message-ID: <a30b9554-e225-42da-b579-acb68683048f@default> (raw)
In-Reply-To: <875zh2s6hf.fsf@gnus.org>

> I had another peek at this, and use-hard-newlines is slightly unusual
> in that many functions bind the use-hard-newlines (and use it), like:
> 
> (defun fill-flowed-encode (&optional buffer) [...]
>   (when use-hard-newlines
> 
> So we'd presumably need to rename the variable, too,

Yes, of course.  That's true of any minor mode.  Often
people do not use the variable, but they certainly can,
in general.

> and then it just seems like it's not worth it, really.

Why?  No reason given.  The right thing to do, to
respect Emacs convention and not mislead users further,
is to fix this.  And yes, of course, that means also
renaming the variable.  This is trivial to fix.





      parent reply	other threads:[~2020-01-23 16:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 17:26 bug#20461: 25.0.50; `use-hard-newlines' Drew Adams
2016-04-30 19:00 ` Lars Ingebrigtsen
2020-01-23  4:58   ` Stefan Kangas
2020-01-23 12:27     ` Lars Ingebrigtsen
2020-01-23 12:55       ` Stefan Kangas
2020-01-23 13:00         ` Lars Ingebrigtsen
2020-01-23 14:51         ` Eli Zaretskii
2020-01-23 14:58         ` Stephen Berman
2020-01-23 18:26           ` Eli Zaretskii
2020-01-23 16:54       ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a30b9554-e225-42da-b579-acb68683048f@default \
    --to=drew.adams@oracle.com \
    --cc=20461@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).