unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Herman@debbugs.gnu.org, Géza <geza.herman@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gregory@heytings.org, 62352-done@debbugs.gnu.org
Subject: bug#62352: Very slow scroll-down-line with a lot of text properties
Date: Sat, 25 Mar 2023 14:41:04 +0100	[thread overview]
Message-ID: <a2c04166-579e-cca9-4670-e9647931da54@gmail.com> (raw)
In-Reply-To: <83h6u9c89f.fsf@gnu.org>



On 3/25/23 13:42, Eli Zaretskii wrote:
>> I analyzed the issue little bit, the root cause of the slowdown is
>> composition handling (yet the composition feature is completely unused
>> by this example).
>>
>> If I comment out these lines in composition_compute_stop_pos(), emacs
>> works better ("normal" scrolling becomes completely fluid,
>> scroll-down-line still freezes, but for a much shorter time):
>>
>>     /* if (charpos < endpos */
>>     /*     && find_composition (charpos, endpos, &start, &end, &prop,
>> string) */
>>     /*     && start >= charpos */
>>     /*     && composition_valid_p (start, end, prop)) */
>>     /*   { */
>>     /*     cmp_it->stop_pos = endpos = start; */
>>     /*     cmp_it->ch = -1; */
>>     /*   } */
>>
>> It seems that emacs does a huge amount of redundant work by scanning
>> approximately the same area over and over again for composition properties.
> This is a non-starter, unfortunately: the display engine _must_
> support character composition, or else some scripts will display
> incorrectly, and some features (like prettify-symbols-mode) will stop
> working.
I'm not saying that this is the solution. I just wanted to point out 
that emacs does unnecessary work. Note, even with this code commented 
out, composition still seems to work. Maybe it's buggy, of course. But 
the point is, it seems possible to fix this performance issue. Maybe 
it's a lot of work and it doesn't worth it. I understand that if this 
issue is closed because of this. But saying that this issue is not a 
(performance) bug is not correct, in my opinion. It is not unreasonable 
to expect that my example file can be scrolled without any problem.

> Get a faster computer, or make your keyboard auto-repeat rate lower?
Maybe there is a 2x single-thread performance factor between my computer 
and a current fast consumer desktop PC. It is highly unlikely that 
getting a faster computer will solve this problem.






  reply	other threads:[~2023-03-25 13:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 20:01 bug#62352: Very slow scroll-down-line with a lot of text properties Herman, Geza
2023-03-21 20:26 ` Eli Zaretskii
2023-03-21 20:39   ` Herman, Géza
2023-03-21 21:58   ` Gregory Heytings
2023-03-25 11:58     ` Eli Zaretskii
2023-03-25 12:33       ` Herman, Géza
2023-03-25 12:42         ` Eli Zaretskii
2023-03-25 13:41           ` Herman, Géza [this message]
2023-03-25 14:02             ` Eli Zaretskii
2023-03-25 15:24               ` Herman, Géza
2023-03-25 16:20                 ` Eli Zaretskii
2023-03-25 17:38                   ` Herman, Géza
2023-03-25 17:49                     ` Eli Zaretskii
2023-03-25 21:39                       ` Herman, Géza
2023-03-26  4:55                         ` Eli Zaretskii
2023-03-26  7:14                           ` Herman, Géza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2c04166-579e-cca9-4670-e9647931da54@gmail.com \
    --to=herman@debbugs.gnu.org \
    --cc=62352-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=geza.herman@gmail.com \
    --cc=gregory@heytings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).