From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' Date: Fri, 25 Nov 2016 16:21:12 -0800 (PST) Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1480119734 3836 195.159.176.226 (26 Nov 2016 00:22:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 26 Nov 2016 00:22:14 +0000 (UTC) To: 25032@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 26 01:22:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAQkr-00005c-Tu for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Nov 2016 01:22:10 +0100 Original-Received: from localhost ([::1]:48565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAQkv-000643-Jx for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Nov 2016 19:22:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAQkp-00063y-IB for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:22:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAQkk-0002xP-K3 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:22:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54748) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cAQkk-0002wu-Hd for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cAQkk-0002wY-9U for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2016 00:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.148011969211268 (code B ref -1); Sat, 26 Nov 2016 00:22:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Nov 2016 00:21:32 +0000 Original-Received: from localhost ([127.0.0.1]:41914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAQkF-0002vg-Uy for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAQkD-0002vQ-5d for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAQk7-0002WL-3A for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:24 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:60288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAQk7-0002WF-0S for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAQk5-00062i-RQ for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAQk0-0002TT-Tf for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:21 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:20821) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAQk0-0002SY-Jh for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:16 -0500 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uAQ0LDVw014825 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 26 Nov 2016 00:21:14 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id uAQ0LDlC011539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 26 Nov 2016 00:21:13 GMT Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id uAQ0LDGN029338 for ; Sat, 26 Nov 2016 00:21:13 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126097 Archived-At: 1. Why is "internal" function `bookmark-set-internal' a _command_ (interactive)? What sense does an "internal" command make? It seems that the `interactive' spec here was a copy+paste mistake. It should be removed, I think. 2. The `interactive' spec for `bookmark-set-internal' seems wrong anyway. NAME is the raw prefix arg? And then NAME is simply taken as is (as STR) and compared using `string-equal'? This cannot be correct. 3. Similarly, why does the doc string of `bookmark-set-internal' say "_Interactively_..."? It should just say that it prompts for a bookmark name and then... And "error" is not easily and commonly understood as a verb - use "raise an error" instead. 4. `bookmark-set-internal' should preferably not accept both args PROMPT and NAME. If NAME is present (e.g. for non-interactive use of `bookmark-set') then PROMPT makes no sense and is not used (and the doc string is wrong about PROMPT in that case). =20 5. In `bookmark-set-internal', a nil third arg should have been used to mean overwrite, not raise an error, as overwriting is still, and always has been, the default behavior of `bookmark-set'. You should have introduced the new value `error', not the new value `overwrite', and kept the default (nil) behavior as overwriting. You will no doubt argue that this does not matter because `bookmark-set-internal' is "internal". But the main command is still, and should still be `bookmark-set'. `bookmark-set-internal' should reflect _its_ behavior for the default case (nil). 6. Error messages, like other messages, should not end with a period. No doubt it is "too late" for #4 and #5. Hopefully not for the rest. In GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17 built on LAPHROAIG Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Configured using: 'configure --without-dbus --without-compress-install CFLAGS=3D-static'