From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Date: Sun, 12 Nov 2023 01:40:22 +0200 Message-ID: References: <9cf7d7d0-33a3-4c07-bd66-bc4c59bdfefb@gmail.com> <39b0057b-ac0c-8271-0fe2-f4deef7ae8d3@gutov.dev> <102c3f66-4d74-49b9-a099-0c54e5d1c635@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25232"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: =?UTF-8?Q?Lo=C3=AFc_?= =?UTF-8?Q?Lema=C3=AEtre?= , 66988@debbugs.gnu.org, Yuan Fu , Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 12 00:41:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1xbU-0006NQ-ML for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Nov 2023 00:41:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1xbP-00054C-Ml; Sat, 11 Nov 2023 18:41:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1xbO-000543-9P for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 18:41:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1xbO-0000Bg-1Q for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 18:41:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1xc2-0003G9-JS for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 18:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 23:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66988 X-GNU-PR-Package: emacs Original-Received: via spool by 66988-submit@debbugs.gnu.org id=B66988.169974607612451 (code B ref 66988); Sat, 11 Nov 2023 23:42:02 +0000 Original-Received: (at 66988) by debbugs.gnu.org; 11 Nov 2023 23:41:16 +0000 Original-Received: from localhost ([127.0.0.1]:54664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1xbH-0003El-Q5 for submit@debbugs.gnu.org; Sat, 11 Nov 2023 18:41:16 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1xbF-0003ET-4C for 66988@debbugs.gnu.org; Sat, 11 Nov 2023 18:41:13 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 06EB45C00E7; Sat, 11 Nov 2023 18:40:27 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 11 Nov 2023 18:40:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1699746027; x=1699832427; bh=VZzJKqvr7/8eR6XetrjCJSG+INyw+2Q6wIw rhqUysz8=; b=VnBYiIh67mXu2Ebm5VPQtPPATPNko0RstQzgUWSQuN3hXSeSD5/ gsbJ43UxZ6lk5WZPOr6kqyWOFRS1b57/JMcksyeOUYdjvQXig9Q45snpTGeoku/Q Iijk712l8l379z6zZdlb1qGW1Or26t62EiNSQBJzEesIVEVc74Bq9tfqx1QD6rk5 HGJpKVgAUzawj8ELRyhfmFf3Sd5dr1+hjxDaFx61O3DOCWxYzXc7T0ATte6hPoMV sQrkYQfi7IRfP41nxW38JPSyGcMjNRE6h1ZT+S61w6S55SenTY17xjJrYjB+mqR+ qHv4IQKHUNh5P5FDxqVgMc9A4Is67/QdTgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1699746027; x= 1699832427; bh=VZzJKqvr7/8eR6XetrjCJSG+INyw+2Q6wIwrhqUysz8=; b=F FksTyO6jz0qWxh3b8OgbNOOSYWqBzqTT02NrVyHLp+QcPVKRi+4fGpTRewQQR5Be zsd8vyKfrlgYdDcU96E2OI3UDDQsRXx8KNJGSW5jv/AKHLfzyQCBkIjZE/xykqX6 w306YcJaS/FNaVuts4B0W3K59ikDzmZBhg1ugETLOCldbXd6eBH1dZ9sxctP/BEA nRFmc4+wvIYX6+YWuQcJ4tPvhiexGN96r11H/mO/zKTJEYfUGNkETfa8FTDZ6HfP W8EfZwimvkzeEvRjnMGPtVdFoHfZzEyLHNESpLpFEKFngV4GqWwScvcKrlHbQsej roJpymjQlMaRJFI92s8TA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddviedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeefjeekvedvfeelfedufeevgeetvdevkeelvddtueetteefudefgfduieekffei leenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Nov 2023 18:40:25 -0500 (EST) Content-Language: en-US In-Reply-To: <102c3f66-4d74-49b9-a099-0c54e5d1c635@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274178 Archived-At: On 11/11/2023 17:43, Loïc Lemaître wrote: > Thanks for the patch ! It fixes the bug. > But unfortunatly, there is another similar bug in > /treesit-forward-sexp/, that you can reproduce with that example: > ({()}); The problem in this case is that the code doesn't parse (one of the nodes in the parse tree is ERROR). Removing either the curlies, or the outer parens pair makes the code valid and the behavior correspondingly better. Although for treesit-forward-sexp to jump between curlies in {()}; we'll also need to add "statement_block" to js--treesit-sexp-nodes.