From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67171: 30.0.50; (At least) some VC commands fail with project-prefix-or-any-command Date: Thu, 7 Dec 2023 02:10:07 +0200 Message-ID: References: <87y1f0cwbj.fsf@melete.silentflame.com> <874jgwff35.fsf@melete.silentflame.com> <90011c72-b18f-5868-2430-66eee97f454e@gutov.dev> <87zfyne5ac.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21496"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 67171@debbugs.gnu.org, sbaugh@catern.com, juri@linkov.net To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 07 01:11:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rB1yx-0005Os-FS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Dec 2023 01:11:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rB1ye-0005B3-Fa; Wed, 06 Dec 2023 19:10:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB1yc-0005As-QG for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 19:10:51 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rB1yc-0005LW-IL for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 19:10:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rB1yo-000166-AJ for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 19:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Dec 2023 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67171 X-GNU-PR-Package: emacs Original-Received: via spool by 67171-submit@debbugs.gnu.org id=B67171.17019078364177 (code B ref 67171); Thu, 07 Dec 2023 00:11:02 +0000 Original-Received: (at 67171) by debbugs.gnu.org; 7 Dec 2023 00:10:36 +0000 Original-Received: from localhost ([127.0.0.1]:40687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rB1yK-00015E-Ms for submit@debbugs.gnu.org; Wed, 06 Dec 2023 19:10:36 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rB1yI-00014z-Oo for 67171@debbugs.gnu.org; Wed, 06 Dec 2023 19:10:32 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 652E65C027C; Wed, 6 Dec 2023 19:10:13 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 06 Dec 2023 19:10:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701907813; x=1701994213; bh=rX+koOdDIcfaCMUFG7Pn2s01iSVRP3CMTKa olaVpHME=; b=YX8ukIqEtAHO5/+PJqc+hxYjpQKHr/2yGsqDnVtswYgjmytN7ba Q0rUW4jMoCGGW1M5EvesKSLS6Jc7e+njBMVzwLgoCeM43KxsUFvxglEGnWvme6jI utfMNHyGqNuM1IcjGR1nOvm9PFafUutBX64jozR9DjbDB3Fc+l21cYBCbtnx2BuK 1hY/wjymk5V1pEPPipaKgf4+KI7rHDFcc9jlsXz5j1OHDF6mxqdGnOFbawIhpVHr kqcW+Ap0CU4DbeItuYDhvmGy79JXDglL8r31pxGMTf0DqismmICDnv7U9XG8ZSId Vu1eV2gjFCvhFMriAcHDmiFAkUPZTF3D16A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701907813; x=1701994213; bh=rX+koOdDIcfaCMUFG7Pn2s01iSVRP3CMTKa olaVpHME=; b=IYd2UQRo+5BqWIGx7ZMsyyWuaL1FrHfoc7tapxaWMysb7UNAeJ4 k3hZKVc4nqwTKw+94o3JJEHkmM3AJ0VCcBP3wyTxh/DWh4w1YOuWvabuK1YQZu9o 82WYcXEalNGyoi1KfkzkxIiDuBtx57h6zbiQY9IRboiiXYnysKhmtJVR0jyFiMsn sFvy8LVhJlkoji+eeoUFs7bXDH+umkGpTXgXWIyiGAxbi6VYWbckct9T2X5ey9TR fWCrw4eMoum9+r2gCT5Z/9X0eUJ+PoT2r/TsD8vGgHdktD1PUEwxxyecfYhyJ2RZ Oh2tsKvs91lN96hV+qCPen2CQPkbFRtPT6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekuddgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Dec 2023 19:10:09 -0500 (EST) Content-Language: en-US In-Reply-To: <87zfyne5ac.fsf@melete.silentflame.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275635 Archived-At: On 06/12/2023 17:09, Sean Whitton wrote: >> Combined with >> >> (put 'vc-print-root-log 'project-switch-with-default-directory t) >> >> somewhere in your init script. >> >> The alternative would be tagging all project-related commands. Even if we also >> check for the 'project-' prefix in command's name, the user-defined commands >> using the project API will be affected (I don't know for how many it would be >> a problem, but still). > > This solution makes sense. We definitely want the user to have a way to > tag additional commands. But couldn't we pre-tag some, like this one, > for example? It is difficult to think of wanting to not have this one > tagged. And the user could always remove the tag in their init. That would be a half-measure still. And why this command but not others? And if others too, then which ones? It might seem natural to you, but it never occurred to add vc-print-root-log to project-prefix-map to me. What other commands would not occur to us both but would to others? Would it make sense to tag all VC commands? Or just consider the 'vc-' prefix as a negative? To consider the "alternative" approach once more, we could recognize the 'project-' commands as the ones that should use project-current-directory-override. But the rest would use default-directory, unless they have a property 'project-related' or something. That would exclude user-defined commands in the beginning, but then again, the difference between binding project-current-directory-override and default-directory might matter only to a small fraction of them.