From: Dmitry Gutov <dgutov@yandex.ru>
To: Po Lu <luangruo@yahoo.com>, 58889@debbugs.gnu.org
Subject: bug#58889: 29.0.50; C-x p f on svn project fails
Date: Sun, 30 Oct 2022 21:25:17 +0200 [thread overview]
Message-ID: <a20e40e1-0c01-d4eb-5ae6-227384cf5960@yandex.ru> (raw)
In-Reply-To: <87tu3lixye.fsf@yahoo.com>
Hi!
On 30.10.2022 09:15, Po Lu via Bug reports for GNU Emacs, the Swiss army
knife of text editors wrote:
> Trying to navigate with C-x p f in an SVN repository fails, because the
> SVN repository has an ignore property with empty lines. This is the
> detailed error.
>
> Debugger entered--Lisp error: (args-out-of-range "" 0)
> #f(compiled-function (entry) #<bytecode -0x1726de7462823143>)("")
> mapcar(#f(compiled-function (entry) #<bytecode -0x1726de7462823143>) ("" ""))
> #f(compiled-function (project dir) #<bytecode 0x187989c589069892>)((vc SVN "~/project/") "~/project/")
> apply(#f(compiled-function (project dir) #<bytecode 0x187989c589069892>) (vc SVN "~/project/") "~/project/")
> project-ignores((vc SVN "~/project/") "~/project/")
> project--dir-ignores((vc SVN "~/project/") "~/project/")
> #f(compiled-function (dir) #<bytecode 0x68383878a42445c>)("~/project/")
> mapcan(#f(compiled-function (dir) #<bytecode 0x68383878a42445c>) ("~/project/"))
> #f(compiled-function (project &optional dirs) #<bytecode -0x1baeb702532f0340>)((vc SVN "~/project/") ("~/project/"))
> apply(#f(compiled-function (project &optional dirs) #<bytecode -0x1baeb702532f0340>) (vc SVN "~/project/") ("~/project/"))
> project-files((vc SVN "~/project/") ("~/project/"))
> project-find-file-in(#("Flipped90:" 0 10 (fontified t)) ("~/project/") (vc SVN "~/project/") nil)
> project-find-file(nil)
> funcall-interactively(project-find-file nil)
> command-execute(project-find-file)
>
> Would someone please take a look at this?
Does this help? I don't have an SVN repository to test.
diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
index 270877041a..f240ebafca 100644
--- a/lisp/vc/vc-svn.el
+++ b/lisp/vc/vc-svn.el
@@ -366,7 +366,7 @@ vc-svn-ignore-completion-table
(with-temp-buffer
(when (zerop (vc-svn-command
t t nil "propget" "svn:ignore" (expand-file-name
directory)))
- (split-string (buffer-string) "\n"))))
+ (split-string (buffer-string) "\n" t))))
(defun vc-svn-find-admin-dir (file)
"Return the administrative directory of FILE."
next prev parent reply other threads:[~2022-10-30 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87tu3lixye.fsf.ref@yahoo.com>
2022-10-30 7:15 ` bug#58889: 29.0.50; C-x p f on svn project fails Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-30 19:25 ` Dmitry Gutov [this message]
2022-11-01 1:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-01 22:47 ` Dmitry Gutov
2022-11-24 19:40 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20e40e1-0c01-d4eb-5ae6-227384cf5960@yandex.ru \
--to=dgutov@yandex.ru \
--cc=58889@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).