Thanks. I've attached an updated patch below.

On 10/6/19 9:19 PM, Lars Ingebrigtsen wrote:
> 
>>   +(defun tags--find-default-tags-dir-impl (current-dir)
> 
> We don't really call functions for "-impl" or the like -- as this
> recurses upwards, what about calling it something more descriptive like
> `tags--find-default-tags-dir-recursively'?

Makes sense.


> 
> This is basically
> 
> (or (tags--find-default-tags-dir-impl default-directory)
>      default-directory)
> 
> so I don't think this intermediary function is needed.

How could I forget the magical "or" :)