* bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el
@ 2014-01-27 16:55 Drew Adams
2014-01-27 17:01 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2014-01-27 16:55 UTC (permalink / raw)
To: 16571
Subject line says it all. None of the defcustoms in `minibuffer.el'
have a :group. They all should.
Zero :group entries is not advised. Adding a :group helps users find
the option.
Presumably, at least group `minibuffer' should apply to the options
defined in `minibuffer.el', which defines that group. Other groups
might also apply.
In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
of 2014-01-23 on ODIEONE
Bzr revision: 116129 monnier@iro.umontreal.ca-20140123150141-qopqqhpm8jqo8a18
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
'CFLAGS=-O0 -g3' LDFLAGS=-Lc:/Devel/emacs/lib
CPPFLAGS=-Ic:/Devel/emacs/include'
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el
2014-01-27 16:55 bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el Drew Adams
@ 2014-01-27 17:01 ` Glenn Morris
2014-01-27 17:34 ` Drew Adams
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2014-01-27 17:01 UTC (permalink / raw)
To: 16571-done
If you actually test it, you'll find they _are_ all in the minibuffer group.
For some time, defcustom defaults to the last specified defgroup.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el
2014-01-27 17:01 ` Glenn Morris
@ 2014-01-27 17:34 ` Drew Adams
2014-01-28 0:17 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2014-01-27 17:34 UTC (permalink / raw)
To: Glenn Morris, 16571-done
> For some time, defcustom defaults to the last specified defgroup.
I see. I didn't know that. Sorry for the noise.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el
2014-01-27 17:34 ` Drew Adams
@ 2014-01-28 0:17 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2014-01-28 0:17 UTC (permalink / raw)
To: Drew Adams; +Cc: 16571-done
>> For some time, defcustom defaults to the last specified defgroup.
> I see. I didn't know that. Sorry for the noise.
It's a recent change: it's only been that way since Emacs-21 or
thereabout ;-)
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-28 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-27 16:55 bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el Drew Adams
2014-01-27 17:01 ` Glenn Morris
2014-01-27 17:34 ` Drew Adams
2014-01-28 0:17 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).