From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50777: Dropping EIEIO from xref (for performance) Date: Sun, 26 Sep 2021 05:16:31 +0300 Message-ID: References: <6b5b14d5-b2ca-8add-f4bf-a3405270c07a@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32348"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 50777@debbugs.gnu.org, Stefan Monnier To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 26 04:17:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUJj6-0008G3-Vf for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Sep 2021 04:17:13 +0200 Original-Received: from localhost ([::1]:33952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUJj5-0002OJ-3B for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 22:17:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUJiw-0002Ku-I8 for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 22:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUJiw-0005lO-AH for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 22:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUJiw-0006ZB-3A for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 22:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Sep 2021 02:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50777 X-GNU-PR-Package: emacs Original-Received: via spool by 50777-submit@debbugs.gnu.org id=B50777.163262260325211 (code B ref 50777); Sun, 26 Sep 2021 02:17:02 +0000 Original-Received: (at 50777) by debbugs.gnu.org; 26 Sep 2021 02:16:43 +0000 Original-Received: from localhost ([127.0.0.1]:35227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUJid-0006YY-93 for submit@debbugs.gnu.org; Sat, 25 Sep 2021 22:16:43 -0400 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:40828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUJia-0006YK-Ua for 50777@debbugs.gnu.org; Sat, 25 Sep 2021 22:16:41 -0400 Original-Received: by mail-wr1-f41.google.com with SMTP id t28so26342275wra.7 for <50777@debbugs.gnu.org>; Sat, 25 Sep 2021 19:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ps2DUxbRZUT+7E279Zklt8grSTpAPPwG8n2nUDmXmoM=; b=WCp9CJYR6zY/rz7EK/yxaRLwJ8n5T1i7pdSG7ITxKfnAvah3BpGs09+V9CQyNZMqrq 6lPLjP+6DPvM0NqluWYQB1vIipIYETPVVSOklL6yRD6PAcOGwKyA6h+Xb2zi0Bmbk7Wn XkXWNI7ouqXIAmk/gcsX/gjjX4aSmqVmGfS/dvBMNwzncVowxVC861jHYQ0fI0MHsONl 0OfEGHvXxapwKs2RsjUNwTIn+K7n5GfRrWa3i1qhPqtqP35YcpRg8Nx5DLBWC+B8rH61 02jNWUCfOWcRToivKBtBg/QutJ9wIOT0Bb0n9EjOHcFHxFgB136xODkrxCEwds2ORxLH Fg8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ps2DUxbRZUT+7E279Zklt8grSTpAPPwG8n2nUDmXmoM=; b=kWriL7XiEMd4vWaN9kHw896V9zKcW1ztHDYdIFneF+33+lTWkKGOx7SMXOVjUD1hHL avpVWv5JBanju5ViwQwfH4zTS8DdjX2IoS5MI/J7Il+YV5gG31B1pDm/Q0uX+7txDdX1 48VgwDdCtwmrrkiX743LMdKYutx+xOW8XjNYcVoq178GHigZ1SugktFbN20B9r3B5ao+ aA5oSD4q0iOtZSzKtjz7DGsuw8l0n9kwZweiT/NE/4nFd78JtLY1RMiQdMKdt3Frv/+F xXMqZqNHxLBuRAyFUHnhZqgpwYZCX+hx3ZgHOWtL9DkfRBVahIP74E9njRKMxWy5xW6W 80rg== X-Gm-Message-State: AOAM531H+fztbIUqYdS748o25B/5qLwteatst4gmQzooBT+y8FxXa0KT iuCEOb3trtlSGgyv8aJPZ3g= X-Google-Smtp-Source: ABdhPJx25AqebP2GK+7VTX3HJVAx5rBmm9ND9j6VYnF6NrLI68GlboEbMwZNlpWsCUg4FfficLCEtA== X-Received: by 2002:a5d:6902:: with SMTP id t2mr18896927wru.23.1632622595074; Sat, 25 Sep 2021 19:16:35 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z7sm12534816wmi.43.2021.09.25.19.16.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Sep 2021 19:16:34 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215543 Archived-At: On 25.09.2021 17:07, Daniel Martín wrote: > Thanks for working on this. I checked the patch and I also see a > similar speedup in my system, working with a large monorepo. Thanks for checking. Could you also do some benchmarking with GNU Grep, as requested in bug#50733? > I agree with Lars, it's better not to rush this change. The change is > invasive and I think I was the only person to report a performance > problem so far in that part of the codebase. I guess it's better to > merge this just after the Emacs 28 branch is cut, so that users in a > stable version are not affected by any potential bug/interface > incompatibility not caught during pretest. Thanks. It has been a known issue for a while, with repeated passes at improving its performance (the "many matches" scenario). Yours has been the second report I've received in the last couple of weeks. I suppose it makes sense to be careful, but the only incompatible packages I have found so far are helm-xref and ivy-xref, both only using with-slots (copied verbatim from xref--insert-xrefs, I guess). It's easy to fix, and the latter can mostly be replaced with the use of xref-show-definitions-completing-read these days. Maybe both of them can.