From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#23129: 25.1.50; Prefix key is not echoed during minibuffer completion Date: Mon, 28 Mar 2016 10:32:35 -0700 (PDT) Message-ID: References: <<>> <<<83shzay6fd.fsf@gnu.org>>> <<5a83c42d-50c1-4217-b1dd-506814a7ed34@default>> <<83io06y3vi.fsf@gnu.org>> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1459186808 6496 80.91.229.3 (28 Mar 2016 17:40:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Mar 2016 17:40:08 +0000 (UTC) Cc: rms@gnu.org, 23129@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 28 19:39:52 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akb2P-0008BP-3w for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Mar 2016 19:33:13 +0200 Original-Received: from localhost ([::1]:41960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akb2O-0001BG-7l for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Mar 2016 13:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akb2J-00017l-8J for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 13:33:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akb2E-00048O-8g for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 13:33:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akb2E-00048E-57 for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 13:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akb2D-0002wQ-Uh for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 13:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Mar 2016 17:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23129 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23129-submit@debbugs.gnu.org id=B23129.145918636611283 (code B ref 23129); Mon, 28 Mar 2016 17:33:01 +0000 Original-Received: (at 23129) by debbugs.gnu.org; 28 Mar 2016 17:32:46 +0000 Original-Received: from localhost ([127.0.0.1]:42318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akb1y-0002vv-IO for submit@debbugs.gnu.org; Mon, 28 Mar 2016 13:32:46 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:38522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akb1w-0002vi-R9 for 23129@debbugs.gnu.org; Mon, 28 Mar 2016 13:32:45 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u2SHWcq7010582 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Mar 2016 17:32:38 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u2SHWbP6016308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Mar 2016 17:32:38 GMT Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u2SHWbBH020754; Mon, 28 Mar 2016 17:32:37 GMT In-Reply-To: <<83io06y3vi.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115667 Archived-At: > > Is `C-x' a prefix key in `minibuffer-local-filename-completion-map' > > at that point? >=20 > What's the significance of minibuffer-local-filename-completion-map > for the purposes of this issue? The use case is a prefix-key binding in a minibuffer keymap. That is, a key that is specifically useful in the context of minibuffer input. The bug is not echoing a prefix key for an active minibuffer. Yes, any prefix key in any accessible keymap will do, to show the problem. But the really useful use cases are prefix keys bound in a minibuffer keymap. > > > How do you mean "should"? > > > > How do I mean "should"? Should. It is helpful for a user > > (as well as consistent) to echo the prefix keys s?he hits. >=20 > There's also "should" as in "it did this yesterday or the last > year". OK. (If that were the case then I would have said that this was a regression.) Anyway, it's now clear what I meant by "should", hopefully. > > > AFAICT, this is a deliberate feature: > > > > Do you have evidence for that? >=20 > I've read the code. It does this explicitly and purposefully, > there's no mistake about that. Fair enough. But just because someone codes something in a particular way, that does not say anything, by itself, about how much thought or user experience went into the design that it reflects (or creates). As I said, if this was by design then this is a design-bug report. The design is flawed/weak and can be improved in this regard. Using prefix keys in the minibuffer might not have been considered a great deal when this was implemented, even if the implementation shows that excluding their echo was deliberate. Prefix keys certainly are allowed to be used, even if users do not benefit from their being echoed. > The function echo_now is the one that echoes the prefix keys; > look at the conditions (and the commentary, for that matter). >=20 > I hope Richard will be able to shed some light on this. The code > is very old, it was present in the initial commit in Jan 1992: >=20 > /* If in middle of key sequence and minibuffer not active, > ^^^^^^^^^^^^^^^^^^^^^ > if (minibuf_level =3D=3D 0 <<<<<<<<<<<<<<<<<<<<<<<<<<<<< OK, it was intentionally coded this way - it was not a coding oversight. It was a design oversight. I see no good reason for the design to exclude the minibuffer case for echoing. Do you? Maybe Richard will provide a good argument.