unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: 42324@debbugs.gnu.org, stefan@marxist.se
Subject: bug#42324: 26.3; Doc string of `seq-concatenate'
Date: Wed, 26 Aug 2020 11:14:52 -0700 (PDT)	[thread overview]
Message-ID: <a12959b1-2625-49b8-82df-004a3f6afaa4@default> (raw)
In-Reply-To: <<83a6yi3q0p.fsf@gnu.org>>

> > In Emacs 26.3, this is the definition of `seq-concatenate':
> >
> > (cl-defgeneric seq-concatenate (type &rest sequences)
> >   "Concatenate SEQUENCES into a single sequence of type TYPE.
> > TYPE must be one of following symbols: vector, string or list.
> >
> > \n(fn TYPE SEQUENCE...)"
> >   (apply #'cl-concatenate
> >          type
> >          (seq-map #'seq-into-sequence sequences)))
> 
> If the bug report is about the doc string, please don't show the
> implementation as your evidence.  The issue is (or should be) with the
> text of the doc string.

You took that out of context.  The context was the
(apparent) change since 26.3, when the bug was reported.
And the bug report is (only) about the doc, including
differences `seq-concatenate' vs `cl-concatenate'.

IF those are now the same thing, and that's said
in the doc (which it apparently is), then #2 of this
bug report disappears.

And #1 is the same as bug #42323.  See also #3.

> > I'd say, overall, that I don't understand the behavior
> > by reading the doc string.
> 
> Which part(s) of the doc string's text are unclear?  The text is short
> and IMO very clear, so I'm puzzled by this bug report to begin with.
> 
> In general, it sounds like what you are after is to understand the
> implementation, and that can only be done by reading the code.  In
> that case, I see no bug to report here.

All of #1, #2, and #3 are only about the doc string.

In any case, the real difficulty is #1, which is bug
#42323.  If that gets fixed properly, AND if
`seq-concatenate' is now exactly the same as
`cl-concatenate' and that's stated in the doc, then
things should be clear.

What's discussed in this thread is, however, relevant
to bug #42323, I think.  Including if the behavior
can change depending on SEQUENCES, as seems to be
the case from looking at the code and `cl-defgeneric'.

The bug report is not about the implementation at
all.  It's about the doc specifying the behavior.





       reply	other threads:[~2020-08-26 18:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<efa23108-da23-4a5b-8bd7-23f25007bed0@default>
     [not found] ` <<CADwFkmma0jyd8P0CNqXp80KghqSqkdFS_fHsMm3v2cXMKmEEqw@mail.gmail.com>
     [not found]   ` <<f5df3cc5-3fad-4295-9f67-e2359317832a@default>
     [not found]     ` <<83a6yi3q0p.fsf@gnu.org>
2020-08-26 18:14       ` Drew Adams [this message]
2020-08-26 18:30         ` bug#42324: 26.3; Doc string of `seq-concatenate' Eli Zaretskii
     [not found] <<<efa23108-da23-4a5b-8bd7-23f25007bed0@default>
     [not found] ` <<<CADwFkmma0jyd8P0CNqXp80KghqSqkdFS_fHsMm3v2cXMKmEEqw@mail.gmail.com>
     [not found]   ` <<<f5df3cc5-3fad-4295-9f67-e2359317832a@default>
     [not found]     ` <<<83a6yi3q0p.fsf@gnu.org>
     [not found]       ` <<a12959b1-2625-49b8-82df-004a3f6afaa4@default>
     [not found]         ` <<83mu2h2rah.fsf@gnu.org>
2020-08-26 18:37           ` Drew Adams
2020-08-26 18:57             ` Eli Zaretskii
2020-08-27 14:27               ` Lars Ingebrigtsen
2020-07-11 16:10 Drew Adams
2020-08-25 22:24 ` Stefan Kangas
2020-08-25 22:46   ` Drew Adams
2020-08-26  6:00     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a12959b1-2625-49b8-82df-004a3f6afaa4@default \
    --to=drew.adams@oracle.com \
    --cc=42324@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).