From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted Date: Wed, 26 Jun 2024 02:14:45 +0300 Message-ID: References: <86tthzwgsw.fsf@mail.linkov.net> <86msnkyt7c.fsf@mail.linkov.net> <30404984-e7ac-4f92-a194-06438dbf2d03@gutov.dev> <867cemquey.fsf@gnu.org> <864j9qqpfx.fsf@gnu.org> <86tthqp2zc.fsf@gnu.org> <86tthnzp19.fsf@mail.linkov.net> <10881a4d-5b44-4b7e-9686-d6f7bf3ddace@gutov.dev> <86r0cmg9wf.fsf@mail.linkov.net> <86tthh9o8f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23659"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71466@debbugs.gnu.org, me@eshelyaron.com, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 26 02:41:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMGit-0005tk-JD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Jun 2024 02:41:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMFUU-0007Rg-S6; Tue, 25 Jun 2024 19:22:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMFU4-0007JS-B2 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2024 19:22:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMFTz-00026h-48 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2024 19:21:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMFOM-00016U-4l for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2024 19:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2024 23:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71466 X-GNU-PR-Package: emacs Original-Received: via spool by 71466-submit@debbugs.gnu.org id=B71466.17193573404206 (code B ref 71466); Tue, 25 Jun 2024 23:16:02 +0000 Original-Received: (at 71466) by debbugs.gnu.org; 25 Jun 2024 23:15:40 +0000 Original-Received: from localhost ([127.0.0.1]:37746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMFNt-00015W-8Z for submit@debbugs.gnu.org; Tue, 25 Jun 2024 19:15:40 -0400 Original-Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]:37017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMFNP-000144-Lq for 71466@debbugs.gnu.org; Tue, 25 Jun 2024 19:15:27 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 06AD111401CE; Tue, 25 Jun 2024 19:14:50 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 25 Jun 2024 19:14:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1719357290; x=1719443690; bh=bLkmkv9yN5W3w4D4x6MCeiHnEJn4qTQzP/2OEnfiUE8=; b= LT4Nhnth2sVQwC/KGSYi+rrX/BeWQRFIJU6aX+nye5saRpSHoK1vxiGvX9dDNC8Z Q6iDXkC4AhXlzDX09thhj6kZmlY1OYUJ3KKGiR05BuFpdlBMJYYrRFdzP3znPbi7 85IMDoan7gZ6u2rbu0+off7BCgB//l13mu/GWWaVpP98ihLpvMXfvFCTwZk2qlpl fo/K2BYdoEX2+pUtPF8f/WsfyGOVC2v8v3d2UFTWNIC80P5zkz53A0LUeB/UCNUz gG8h+xigJuWr9/0xSjKKVVFCRg8N4nQdwL6r0C36ElEfugYe6NlWJnuPLuhCD1PK vAhwIv9S69nvwhCpFuqSUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719357290; x= 1719443690; bh=bLkmkv9yN5W3w4D4x6MCeiHnEJn4qTQzP/2OEnfiUE8=; b=u y0g4nt0KZHKvexWZnCU1Vo6smb8MulSLbwK1CjWuAI34OSjmhTMHVvVcFxoFEni9 Oc8LFKLqyKtQncRfoElB4Vb2Kjf8FgScpsw4fhTLsroOqAl3qfdIqZJrNqHK85UJ woK7TUHgTudCdiUMouXOXssJxULlUP0FzzSXzxAzlIt3ILV0slpPmOpCKy+dFtUc 94TT8T/xH02obCgPBiPnXYhfylEpnBXxeJc42nhCJzWKXyi7tzN2XYNzNSxNufgQ mE/2GUb0KpGjjzNLevRCZUfPAHqqkM7oX9Fj9A1wrEemPyDNZ1S9Y0m4FWa7Nc7o /ETuaI/DdJBwfKYPfyw8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtddugddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveegudej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jun 2024 19:14:48 -0400 (EDT) Content-Language: en-US In-Reply-To: <86tthh9o8f.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287905 Archived-At: On 25/06/2024 15:54, Eli Zaretskii wrote: >> Date: Tue, 25 Jun 2024 01:42:46 +0300 >> Cc: Eli Zaretskii,me@eshelyaron.com,71466@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 24/06/2024 09:27, Juri Linkov wrote: >>> I still don't understand how duplicating revert-buffer >>> >>> +(defun xref-revert-buffer () >>> + "Refresh the search results in the current buffer." >>> + (declare (obsolete revert-buffer "30.1")) >>> + (interactive) >>> + (let (restore-functions) >>> + (when (boundp 'revert-buffer-restore-functions) >>> + (run-hook-wrapped 'revert-buffer-restore-functions >>> + (lambda (f) (push (funcall f) restore-functions) nil))) >>> + (prog1 (xref--revert-buffer) >>> + (mapc #'funcall (delq nil restore-functions))))) >>> >>> can be better than what Eshel proposed with an alias: >>> >>> + (define-obsolete-function-alias 'xref-revert-buffer #'revert-buffer "30.1") >> That is my opinion as well: better obsolete it this way. > Why obsolete it at all? If we use an alias without obsoleting, I > think everyone wins. No? Well, we normally obsolete functions that aren't in use anymore, nor recommended for third parties. Right? We can stop from obsoleting it now (just make an alias), but add a comment to do that in the next Emacs release. How about that?