From: Okamsn via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: michael_heerdegen@web.de, 73431@debbugs.gnu.org
Cc: philipk@posteo.net, nicolas@petton.fr, monnier@iro.umontreal.ca
Subject: bug#73431: Add `setf` support for `stream.el` in ELPA
Date: Wed, 02 Oct 2024 01:02:47 +0000 [thread overview]
Message-ID: <a0e70d11-dacd-4636-9f3c-7cbe2483d5ee@protonmail.com> (raw)
In-Reply-To: <87y138hjij.fsf@web.de>
Michael Heerdegen wrote:
> Okamsn via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs@gnu.org> writes:
>
>> Please see the attached file. It changes streams to be structs, warns
>> that streams are not mutable, adds a creation method for arrays that
>> doesn't create intermediate sub-arrays, and adds some methods for
>> streams for more of the seq.el functions.
>
> Thank you for working on this.
>
>> * stream.el (stream): Define the structure using 'cl-defstruct'.
>
> Does changing the internal representation of streams have an effect
> on the speed of the run code?
I think that it does make it slower. I am trying to test it, and I think
that making records is slower than making cons cells. I think that
accessing the rest of the stream takes longer because the accessors
created by `cl-defstruct` always perform type checking. It seems to take
about twice as long when compared to naively using `car` and `cdr`.
Do you think that it would be better to disable the type checking in the
accessors? If so, would you please share how to do that? The manual
talks about using `(optimize (safety 0))` in a declare form, but it also
seems to say that it cannot be done locally for just the `cl-defstruct`
usage. If it cannot be done, do think it makes sense to use
`make-record` directly, along with custom function to replace the
generated accessors?
> I don't like these, apart from seq-concatenate.
>
> That we have a unified interface for different types of seqs doesn't
> mean we must implement every functionality for every type - we can limit
> to those where it makes sense. If you have to translate the complete
> stream into an intermediate seq type to implement a feature (like
> sorting) hints at that it might not make sense. And I think indeed: if
> you need to sort any data than you probably should not use streams to
> represent them at all. In the rare cases where this really makes sense
> conceptually it is even better to do the translation into a different
> seq type explicitly. Converting the result back into a delayed list
> makes hardly sense. This is inefficient and leads to bad style.
OK, I will remove them. For the sorting, I looked at Scheme's SRFI-41
(https://srfi.schemers.org/srfi-41/srfi-41.html), which says the
Quicksort could be used for its implementation of streams, but I did not
look in detail.
For passing a stream to the creation function `stream`, do you think it
makes sense to make a shallow copy of the stream via `stream-delay`
(similar to `seq-copy`), or do you think it makes sense to return it
unmodified, which is how I've written it currently?
Thank you.
next prev parent reply other threads:[~2024-10-02 1:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 1:33 bug#73431: Add `setf` support for `stream.el` in ELPA Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-24 10:15 ` Philip Kaludercic
2024-09-24 13:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-25 0:17 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-25 2:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-25 20:22 ` Philip Kaludercic
2024-09-26 13:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-27 15:11 ` Philip Kaludercic
2024-09-27 16:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-27 20:08 ` Philip Kaludercic
2024-09-27 20:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-28 3:08 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-28 14:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-29 19:30 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-30 22:19 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-02 1:02 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-10-02 19:39 ` Philip Kaludercic
2024-10-03 0:19 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-04 8:55 ` Philip Kaludercic
2024-10-05 2:44 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-05 9:14 ` Philip Kaludercic
2024-10-06 1:36 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-05 13:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-06 0:37 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-27 23:55 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0e70d11-dacd-4636-9f3c-7cbe2483d5ee@protonmail.com \
--to=bug-gnu-emacs@gnu.org \
--cc=73431@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
--cc=nicolas@petton.fr \
--cc=okamsn@protonmail.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).