From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized Date: Thu, 10 Sep 2020 20:16:04 +0200 Message-ID: References: <588A0102.7010704@gmx.at> <588B108E.9070501@gmx.at> <588B1437.9010303@gmx.at> <588B4F7C.40909@gmx.at> <588C5003.4070409@gmx.at> <87r1rhbu2s.fsf@gnus.org> <83wo18pvoh.fsf@gnu.org> <17a425a3-7b6e-56bc-40a3-35ac78fdaa6a@gmx.at> <56ee5ed9-fd85-b5c3-6aba-d51332398f03@cornell.edu> <818f2053-a996-7ade-c1cf-6592b6d2cde5@gmx.at> <4869c79f-2f3b-cafb-0459-c6f39f9a6bd5@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2808"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Magne Ingebrigtsen , 25542@debbugs.gnu.org, Noam Postavsky To: Ken Brown , Dani Moncayo , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 10 20:18:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGR98-0000cd-RD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 20:18:10 +0200 Original-Received: from localhost ([::1]:41658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGR97-0000IO-Lo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 14:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGR82-0000GV-AB for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGR82-00027M-0g for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGR81-0004M2-Rw for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 14:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 18:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25542 X-GNU-PR-Package: emacs Original-Received: via spool by 25542-submit@debbugs.gnu.org id=B25542.159976180816716 (code B ref 25542); Thu, 10 Sep 2020 18:17:01 +0000 Original-Received: (at 25542) by debbugs.gnu.org; 10 Sep 2020 18:16:48 +0000 Original-Received: from localhost ([127.0.0.1]:41142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGR7o-0004LY-1T for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:16:48 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:43001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGR7m-0004LL-2f for 25542@debbugs.gnu.org; Thu, 10 Sep 2020 14:16:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599761766; bh=9HDOHiX3wIyUcBVNqbpiZpmrvJ12O2MEl7NP6fSMF9Q=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=WHVq2aP74zEn9oVk/JJIxcxzTtjQHmBUGQi0WVO6gcipDbuG8M/Nj+cC8X3gSxPCE LwIHVZvY8uNUn8Kf+CLglwsF3K0o74IBOf0ZGmnYpeRvRkselLs/s4XOj7LMC+FbQP PuTrgVZkYhac5KGtV6ALGDbmrONe9RQ09m20I1Uc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([46.125.249.14]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M3lYB-1kGA8D1qkN-000rWK; Thu, 10 Sep 2020 20:16:06 +0200 In-Reply-To: <4869c79f-2f3b-cafb-0459-c6f39f9a6bd5@cornell.edu> Content-Language: en-US X-Provags-ID: V03:K1:6a+4KSresisGZteN8ilUIfL3/HioMw5BPfqYb3Ubaw6PRHAW8iG w4UGIc7h613EfbLsETAffnsTEHNS8UJFLRt+WchcQJrqiMWaNeVTOc6EASiwdtOLGciZeKj w9IY09lEEqQDaAouOdMKYX/wBjIcHkSPhDV1W6OH8ZpbZ2UraS8RTlkNtv4Aat9ZgmsOemH k8UZxcY5sIc+bqiVJL7ew== X-UI-Out-Filterresults: notjunk:1;V03:K0:tNCQYK90Xys=:lwFZ38jGetb0tqboB3zZIv S6cN2rRRKdtMhNWJuXD8zcs0HakvtiX2G9FouV4plkDpPq6UtP7Ow9Z7ZAeR/Cv7E0O1zKJUc 4i8eJS0vyLxRRkU3gMFw2km0YdXATNRrErv/bnp+qhBUVux1HgQXDPKq4LJlNZPcy9TZExXbs nj3+7YBFZcZ3VWNq/r2oqxs6hoqMAk846C0wUQ8XmgYrILIZafjQ23oJvGrHydkWk0ivy35xd Ouan1FWgCYGxtVn9O/ZG72ZoW14cV4BYsqfxVtPLTribuIsmR8N2lB9svmtDGbejZkSWphqFx x/vDmGkhqpEqWzM1UZ/pzuOj37KnrWA+B55OkPueUXjmjgLYZLIjofM1EZSxJv6s4qmxcKlf9 8+v0TZTRs+Ku7mwirvrRA2XkzEzrA711JrScQgZu2iBj3YR9QO48zOYhSFOuYVI9doGUGx+d0 hqKbi1L3e5El0QIWLhaCHo2Gpja2spgKlkoDa52KAFmHYnBeoPJEPNKLNowIjb5RXCFxpKgkK sFPvesPuCCMnta35bMgMlFBy6nRZfgHHxhZDE2TR5xuPfr0SadHv1rzIAXDOGeG0Pcf8NDilr e83HapM/fxi7GjHzM4b79oJ3KtInY7FT9wA6hS2rOYWnOxi+Ii2YRSANxXnO6xkzqbhS3IKmC 0H8ySBADTPq8Q0VGZRcA7l/j+1C09QxQS+DOKfDBV+fXwnroFmVHoMNqIR+6Av76FApXgYsa6 uRD5RI0c/rlURqILPZ1igYug+ShteEsLItEdxavyhccj2u5Um3lJEo2VGJfVVGT1HLGEL/E1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187751 Archived-At: >> (2) Does 'toggle-frame-fullscreen' the second time when you type F11 >> correctly call >> >> (set-frame-parameter frame 'fullscreen fullscreen-restore) >> >> with 'fullscreen-restore' equal to 'maximized' at all? > > No. The value of 'fullscreen-restore' is nil. But if I repeat the experiment with the taskbar on the bottom, the value of fullscreen-restore is 'maximized'. Thanks for telling me what I forgot to ask. IIUC this means that after maximizing the frame with the mouse, the value of (frame-parameter nil 'fullscreen) is nil. Correct? And what is its value if, instead, you maximize the frame via 'toggle-frame-maximized'? In either case the bug should be a consequence of the earlier mentioned if (x < 0 && y < 0) store_frame_param (f, Qfullscreen, Qmaximized); so we do not remember in the fullscreen parameter that the frame has been maximized. Apparently some check _is_ needed (why?) so probably using if (x < 0 || y < 0) store_frame_param (f, Qfullscreen, Qmaximized); instead will fix it. Can you try that (as I said elsewhere it will then fail for borderless, maximized frames)? martin