From: Jim Porter <jporterbugs@gmail.com>
To: Drew Adams <drew.adams@oracle.com>, Eli Zaretskii <eliz@gnu.org>
Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org>,
"juri@linkov.net" <juri@linkov.net>
Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus
Date: Sun, 12 Dec 2021 14:12:16 -0800 [thread overview]
Message-ID: <a0285fd1-246b-498d-ade2-60d29587268e@gmail.com> (raw)
In-Reply-To: <SJ0PR10MB5488D900716C8793543EBF46F3739@SJ0PR10MB5488.namprd10.prod.outlook.com>
On 12/12/2021 1:00 PM, Drew Adams wrote:
> Caveat: I'm not following this thread. FWIW:
>
> 1. In my code I have _lots_ of menu separators that
> are apparently in what you call the old naming
> convention.
That's fine. I'd prefer we *not* update old menu separators, since
that's a compatibility break. The only exception would be for existing
context menu separators, since they're pretty new anyway, so the chance
of any code relying on the old context menu names is low.
> 3. I think there's zero need for any naming
> convention for menu-item names, whether
> separators or other.
The goal was to make it easier to remember the names of the separators
if you wanted to add a new item after a particular separator that had
already been added. It's easier to remember if they're all
`foo-separator' instead of a mix of styles.
> 4. As I stated early on in this thread, I think
> it's misguided to prevent the use of duplicate
> separators. If someone wants such duplicates
> for some reason (and there can be any number
> of reasons), let them be. And if someone, for
> some reason, wants to prevent such duplicates
> they can do so easily enough, manually or by
> code.
Technically, this is already possible by using extended-format menu
items. Only simple separators are de-duplicated. So this would be
de-duplicated:
(define-key menu [foo-separator] '("--"))
But this wouldn't:
(define-key menu [bar-separator] '(menu-item "--"))
That's not documented though, and I'm not sure what promises we should
make here. It might be better to have a more-explicit way of opting into
de-duplication, but I'm not sure what that would be off-hand.
It may be possible for context menu functions to be more careful about
the insertion of separators so that duplicates never crop up in the
first place. However, that would take a bit of experimentation, and I'm
not sure of all the pros and cons of a solution like that. Maybe Juri
has some thoughts on this though.
next prev parent reply other threads:[~2021-12-12 22:12 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 5:58 bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Jim Porter
2021-12-05 9:39 ` Juri Linkov
2021-12-06 4:07 ` Jim Porter
2021-12-05 17:59 ` Juri Linkov
2021-12-06 4:50 ` Jim Porter
2021-12-06 9:23 ` Juri Linkov
2021-12-07 3:54 ` bug#52293: 29.0.50; [PATCH v2] " Jim Porter
2021-12-07 8:19 ` Juri Linkov
2021-12-08 4:37 ` bug#52293: 29.0.50; [PATCH v3] " Jim Porter
2021-12-08 12:59 ` Eli Zaretskii
2021-12-08 17:43 ` Jim Porter
2021-12-08 19:07 ` Juri Linkov
2021-12-08 19:47 ` Eli Zaretskii
2021-12-09 9:06 ` Juri Linkov
2021-12-09 9:39 ` Eli Zaretskii
2021-12-12 4:02 ` Jim Porter
2021-12-12 7:02 ` Eli Zaretskii
2021-12-12 20:27 ` Jim Porter
2021-12-12 20:43 ` Eli Zaretskii
2021-12-12 21:59 ` Jim Porter
2021-12-13 12:23 ` Eli Zaretskii
2021-12-13 18:13 ` Jim Porter
2021-12-12 21:00 ` bug#52293: [External] : " Drew Adams
2021-12-12 22:12 ` Jim Porter [this message]
2021-12-12 23:14 ` Jim Porter
2021-12-13 1:16 ` Drew Adams
2021-12-13 1:46 ` Jim Porter
2021-12-13 2:41 ` Drew Adams
2021-12-13 8:47 ` Juri Linkov
2021-12-13 17:25 ` Jim Porter
2021-12-13 18:58 ` Juri Linkov
2021-12-14 5:41 ` Jim Porter
2021-12-14 8:30 ` Juri Linkov
2021-12-14 13:04 ` Eli Zaretskii
2021-12-14 16:49 ` Drew Adams
2021-12-14 20:51 ` Juri Linkov
2021-12-14 22:02 ` Drew Adams
2021-12-15 8:59 ` Juri Linkov
2021-12-15 18:10 ` Drew Adams
2021-12-15 18:24 ` Juri Linkov
2021-12-15 21:36 ` Drew Adams
2021-12-16 17:20 ` Juri Linkov
2021-12-16 17:51 ` Drew Adams
2021-12-16 17:56 ` Drew Adams
2021-12-17 8:20 ` Juri Linkov
2021-12-17 17:21 ` Drew Adams
2021-12-15 0:17 ` Jim Porter
2021-12-15 8:57 ` Juri Linkov
2022-01-01 7:13 ` Jim Porter
2022-01-02 19:27 ` Juri Linkov
2022-01-03 6:14 ` bug#52293: 29.0.50; [PATCH v4] " Jim Porter
2022-01-04 8:19 ` Juri Linkov
2022-01-04 21:14 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0285fd1-246b-498d-ade2-60d29587268e@gmail.com \
--to=jporterbugs@gmail.com \
--cc=52293@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).