From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK. Date: Wed, 30 Mar 2022 14:55:42 +0000 Message-ID: <_cZTGI5IOQhThtQm00iO5TXOSJmyqIhe7IUH9aSYeFx0qifXWHb21bLoNwa58ywtk0EShgtJOaBcUy6ExX0_MWu15uk9Azl2xKUoTXi77y8=@rjt.dev> References: <83bkxn8wpp.fsf@gnu.org> <9EqAhFUloeB4kQNtbW9VlWwN8Z3sNW2ymLkuwBA1XV5j19ttoHI_X78nrUFrz_2uqvJAu2DuGDJk0SMb2XeNUZVQgsp7EmJpzWoaWemfDVg=@rjt.dev> <834k3f8tax.fsf@gnu.org> <87tubfva1q.fsf@yahoo.com> Reply-To: Randy Taylor Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7752"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54633@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 16:57:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZZl7-0001lq-NP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 16:57:18 +0200 Original-Received: from localhost ([::1]:50740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZZl6-0007rt-I9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 10:57:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZZks-0007of-Pw for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 10:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZZks-0003cJ-Hb for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 10:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZZks-0003xV-9f for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 10:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54633-submit@debbugs.gnu.org id=B54633.164865217415150 (code B ref 54633); Wed, 30 Mar 2022 14:57:02 +0000 Original-Received: (at 54633) by debbugs.gnu.org; 30 Mar 2022 14:56:14 +0000 Original-Received: from localhost ([127.0.0.1]:36671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZZk6-0003wH-7e for submit@debbugs.gnu.org; Wed, 30 Mar 2022 10:56:14 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:59336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZZjq-0003vX-FW for 54633@debbugs.gnu.org; Wed, 30 Mar 2022 10:56:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail; t=1648652148; bh=by+DIqcSfknXANFeQIQ8i5MfaYOP0LwfVS2niq6V3bc=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=EknelA3pLjQ9fzByUqW/erVoFbLMQwrJwAVADqXrQSPM2bw+rBbUx8woTGlLamsAS TnTHDPOpAUhtDwLFRW5YPVaXh3d42WU+2xVkzEVEdXNj0G5cwI8zaAm2obpQ9ddBQl 4byA09aVSofN//wBZOX2EE1Da/7H9jP+fa3mXs/8mvB+6gpES0jsiagNJo0SgKP/1M zS+uNHus2NLdKv3KL2U0Au/WZgVl36nuWwK42OY7nJMc8uvXwk+sDUf6QYak/7BwFo ZgfHaVCHtEeGNjBoBdO5u34KG+yYbKl/EPaXa32XKuIt9GaOpUM/7w/vogMoyKgS20 4NKge/OyrbKPA== In-Reply-To: <87tubfva1q.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229116 Archived-At: ------- Original Message ------- On Wednesday, March 30th, 2022 at 09:34, Po Lu wrote: > Eli Zaretskii eliz@gnu.org writes: > > > Thanks. But your patch touched more than just the PGTK build. For > > > > w32, for example, I see no reason to make any changes; do you? > > > > Likewise for NS. > > > > Po Lu, do you agree that only PGTK needs a fix? If co, can you > > > > suggest a fix for PGTK only? > > I didn't yet test this, but it should work correctly. Randy, please > > test. Thanks. > > Native image APIs are used on Haiku and NS for GIF image support, so > > this probably doesn't have to change. > > diff --git a/configure.ac b/configure.ac > > index 93c821eda0..99b2ecc669 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -4292,7 +4292,8 @@ AC_DEFUN > > fi > > elif test "${HAVE_X11}" =3D "yes" && test "${with_gif}" !=3D "no" \ > > || test "${HAVE_W32}" =3D "yes" || test "${HAVE_NS}" =3D "yes" \ > > - || test "${HAVE_BE_APP}" =3D "yes" || test "$window_system" =3D "pgtk";= then > > + || test "${HAVE_BE_APP}" =3D "yes" || test "$window_system" =3D "pgtk" = \ > > + && test "${with_gif}" !=3D "no"; then > > AC_CHECK_HEADER(gif_lib.h, > > # EGifPutExtensionLast only exists from version libungif-4.1.0b1. > > # Earlier versions can crash Emacs, but version 5.0 removes EGifPutExtens= ionLast. Works for me. Makes sense to only apply it to PGTK. Thanks.