From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK. Date: Wed, 30 Mar 2022 13:34:22 +0000 Message-ID: <_VSsAZMe_TBK2D6Qs_LdHklodsyPeP8VC78M4YpEYWj7A3aRh6aDMeccUkdVqw7hjZ2QXxWAxBf_MqYBp8VI_3Q_gqL0B-Gl79AQPpwXFhY=@rjt.dev> References: <83bkxn8wpp.fsf@gnu.org> <9EqAhFUloeB4kQNtbW9VlWwN8Z3sNW2ymLkuwBA1XV5j19ttoHI_X78nrUFrz_2uqvJAu2DuGDJk0SMb2XeNUZVQgsp7EmJpzWoaWemfDVg=@rjt.dev> <834k3f8tax.fsf@gnu.org> Reply-To: Randy Taylor Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39884"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 54633@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 15:38:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZYWk-000AFm-G6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 15:38:23 +0200 Original-Received: from localhost ([::1]:41026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZYWj-0005ip-Bl for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 09:38:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZYTX-0002Wb-1L for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZYTW-0007vv-Nx for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZYTW-0001MO-H2 for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54633-submit@debbugs.gnu.org id=B54633.16486472805197 (code B ref 54633); Wed, 30 Mar 2022 13:35:02 +0000 Original-Received: (at 54633) by debbugs.gnu.org; 30 Mar 2022 13:34:40 +0000 Original-Received: from localhost ([127.0.0.1]:34813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZYTA-0001Ll-GB for submit@debbugs.gnu.org; Wed, 30 Mar 2022 09:34:40 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:35027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZYT9-0001LW-8L for 54633@debbugs.gnu.org; Wed, 30 Mar 2022 09:34:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail; t=1648647272; bh=m5hVYSQHrPgt/toq2W1L7qoH/qtiVRCUgf5/HvHb+0A=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=Zk+ZwO6g4688Zit2Uq1ZICkJZXC8RavBUmNJkXhVI87P2ADr/NvJVjDxbDTa3G7kN QxIIVKsG0sybpI19phpI3aM+Dk792CUaOLK9QHb4SKt2YMOr8QSnNBKDJyL83JQ+GU wz9HkkzlUa64KMe18bxHScbNiULjJrM3a7aFLib8v0QUeaEoXQX1eT/xqXplGzsD2t YrbunwhTUS3p5cvpVDDT+Bopy8ol/i3KIqrGkd7SmVRiJRx1vxNWiceOIgD9IyUCoO pO2L32bxxn8Hg0aR1cMDEgXiLZJ2D5os3a0HJ1MU0pqYGaIHQj7xGSS3L1jaqE9RF+ y0w856sjfPhmg== In-Reply-To: <834k3f8tax.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229107 Archived-At: ------- Original Message ------- On Wednesday, March 30th, 2022 at 09:27, Eli Zaretskii wrote= : > > Date: Wed, 30 Mar 2022 12:42:54 +0000 > > > From: Randy Taylor dev@rjt.dev > > > > Cc: 54633@debbugs.gnu.org > > > > When I build Emacs I specify "--without-gif". > > > > When using PGTK: > > > > - With the original code and specifying "--without-gif", here is what c= onfigure gives me: Does Emacs use a gif library? yes -lgif > > > > - With the patch and specifying "--without-gif", I get this (as expecte= d): Does Emacs use a gif library? no > > > > - With the patch, if I remove "--without-gif" or specify "--with-gif=3D= yes", I get this (as expected): Does Emacs use a gif library? yes -lgif > > > > When using X11: > > > > - With the original code and specifying "--without-gif", here is what c= onfigure gives me (as expected): Does Emacs use a gif library? no > > > > - With the original code and removing "--without-gif" or specifying "--= with-gif=3D"yes", here is what configure gives me (as expected): Does Emacs= use a gif library? yes -lgif > > > > The check in the code for "--without-gif" only applies to X11, but not = the other systems. > > > > This patch fixes it to apply for all the systems in that check, in the = same fashion as the SVG check (see line 2660 in configure.ac). > > Thanks. But your patch touched more than just the PGTK build. For > > w32, for example, I see no reason to make any changes; do you? > > Likewise for NS. > > Po Lu, do you agree that only PGTK needs a fix? If co, can you > > suggest a fix for PGTK only? If someone specifies "--without-gif", then Emacs should not build with gif = support. That is why I made the check to apply for all systems. The same be= haviour already applies to all the other formats, like SVG which I mentione= d.