From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string Date: Mon, 05 Dec 2022 13:52:07 +0000 Message-ID: <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> References: <87sfhudrfu.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39209"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 14:53:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2Buh-0009xD-RF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 14:53:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2Bu4-0002kT-AV; Mon, 05 Dec 2022 08:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Bu3-0002k5-5l for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2Bu2-0006c8-Sa for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2Bu2-00018Z-Cr for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 08:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59833 X-GNU-PR-Package: emacs Original-Received: via spool by 59833-submit@debbugs.gnu.org id=B59833.16702483434356 (code B ref 59833); Mon, 05 Dec 2022 13:53:02 +0000 Original-Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 13:52:23 +0000 Original-Received: from localhost ([127.0.0.1]:36139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2BtP-00018C-Gv for submit@debbugs.gnu.org; Mon, 05 Dec 2022 08:52:23 -0500 Original-Received: from mail-40136.proton.ch ([185.70.40.136]:30109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2BtN-000186-5C for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 08:52:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670248333; x=1670507533; bh=4trHv5Zm96d03aaYsGZOZTVTz37fN//Mwhl9UbdMXh4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=FdWckVszvmNSDt9FAI72GsEsm1WEGY3Tca0KjHs4rsh1FaZPoRr2oFw5rQjJl0JVB TcDWhyO50mxYBQdAdLF4qv7Ezh+dd3P1f/4jRgWDq9nLh36KyibKTH7NyutXg+ub8s 2aqmj7ShMMdqIHrBnY8wq7bKRRqDN39+f1Vxu8UHUzX9LC+BdyStRdSzpckwTq2qpl GClpFTU21/+Xe+VFsZzfbN6O49rzeiGorFLa9Cna3V7JvjTb0VewXUYyG9xHHqyVRN bEUh0CEoCYLDaaA3Pfm9NE+VaF0HKHA3ZjhPzYSNZI82EMxBlapHzudNHnslNYNLdD 8agXOEgPKJLhQ== In-Reply-To: <87sfhudrfu.fsf@thornhill.no> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250025 Archived-At: On Monday, December 5th, 2022 at 06:24, Theodor Thornhill wrote: >=20 >=20 > Jostein Kj=C3=B8nigsen jostein@secure.kjonigsen.net writes: >=20 > > Hey everyone. > >=20 > > When opening a JSON-file in a build from emacs git emacs-29 > > release-branch, Emacs still defaults to json-mode. > >=20 > > Fontification in json-mode looks correct and proper. > >=20 > > When trying to insteas use json-ts-mode, literally everything is > > fontified as strings. > >=20 > > When I change the code to disable the string-fontification rule, this > > yields a buffer where everything is fontified using default-face. That > > is, no other fontification is taking place. > >=20 > > Have this mode really been tested? Should it be working? Or is there an > > error on my end? > >=20 > > Could someone else please give json-ts-mode a try? >=20 >=20 > Yeah, you are correct. It seems we've had a regression in this commit, > 0ed313642227afdeccf48057eea458edca9d2962. >=20 > I believe this is the offending commit - what do you think, Randy? >=20 > Specifically the lhs should be fontified differently than the rhs, so > not everything is a string. >=20 > Do you want to do that, Randy, or should I? >=20 > Theo Can someone show me an example JSON file that shows this problem? Everythin= g looks the same for me in json-mode and json-ts-mode, except for the json-= ts-mode extras (even with Theo's patch) both with my own Emacs config and e= macs -Q. I must be doing something very silly.