From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#74339: 30.0.92; CC Mode stomps C TS Mode Date: Sat, 16 Nov 2024 21:56:03 +0000 Message-ID: References: <86cyiwimlr.fsf@gnu.org> <864j47iobz.fsf@gnu.org> <86ttc7f7jo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5219"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, 74339@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 16 22:57:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tCQnK-0001AC-6d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Nov 2024 22:57:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCQmu-0003kw-Ol; Sat, 16 Nov 2024 16:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCQms-0003kb-Hr for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2024 16:57:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCQms-0003vN-9m for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2024 16:57:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=From:In-Reply-To:MIME-Version:References:Date:To:Subject; bh=dFJpuW4yk99LZz7LY2kwWILquyCkLqC6aefEyNdD7zY=; b=JjEq4yzu7o9q8s2mktJwZZKwLz5NQ7zwVlXcKEH/M6mOIB0PUdMoPmrONoUA5AZQwoNtzBZQGNYnmFv+165uoUs3hd+/uAwUV0fLWpG272vJykRyKs0CkhGfF548dgJ8WZttMF6B/+46ROU1EmF4sMXrCMVyyrC9XeMWRTdZpBHqlR5uJEjBltSQ9gIoc0fyhy1A7I+EUYOrXsvHz6ymFj+WilQPU7h2Z7KvSJRQQnXwtj4He1Ts23X1rpLMeSJJr0HEL/rOnXPNg9PSF2j3nMrmdYZsZeRyd/OITFG9Urh2SPiCZ8iKmcgwP7Rvq54qemYsPP09d+S3ZjibN2ri6A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tCQmr-0001NO-SY for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2024 16:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2024 21:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74339 X-GNU-PR-Package: emacs Original-Received: via spool by 74339-submit@debbugs.gnu.org id=B74339.17317941755231 (code B ref 74339); Sat, 16 Nov 2024 21:57:01 +0000 Original-Received: (at 74339) by debbugs.gnu.org; 16 Nov 2024 21:56:15 +0000 Original-Received: from localhost ([127.0.0.1]:55055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCQm6-0001MI-Ge for submit@debbugs.gnu.org; Sat, 16 Nov 2024 16:56:14 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:22139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCQm2-0001M3-Fy for 74339@debbugs.gnu.org; Sat, 16 Nov 2024 16:56:13 -0500 Original-Received: (qmail 16405 invoked by uid 3782); 16 Nov 2024 22:56:04 +0100 Original-Received: from muc.de (p4fe151f0.dip0.t-ipconnect.de [79.225.81.240]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 16 Nov 2024 22:56:03 +0100 Original-Received: (qmail 17004 invoked by uid 1000); 16 Nov 2024 21:56:03 -0000 Content-Disposition: inline In-Reply-To: <86ttc7f7jo.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295499 Archived-At: Hello, Eli. On Sat, Nov 16, 2024 at 18:49:15 +0200, Eli Zaretskii wrote: > > Date: Sat, 16 Nov 2024 15:40:24 +0000 > > Cc: acm@muc.de > > From: Alan Mackenzie > > > Alan, please help us release Emacs 30 sooner rather than later by > > > agreeing to the proposed changes in cc-mode.el and in c-ts-mode.el. > > I don't and can't agree to these changes as they're currently proposed. > > My concerns expressed over the last few days haven't been addressed; > > they've merely been dismissed. In effect, you're proposing just > > reverting my patch from May, without addressing the reasons for that > > patch. > No, not to revert: to amend it in relatively minor ways. No. Nullifying it's main purpose and leaving only a toothless hulk is not relatively minor. The purpose of the patch was to protect CC Mode's symbols. It had unfortunate side effects, hence this bug. > Specifically, I'm asking not to add these entries to > major-mode-remap-defaults: > (add-to-list 'major-mode-remap-defaults '(c++-mode . c++-ts-mode)) > (add-to-list 'major-mode-remap-defaults '(c-mode . c-ts-mode)) > (add-to-list 'major-mode-remap-defaults '(c-or-c++-mode . c-or-c++-ts-mode)) > Instead, _remove_ them from the list (if they are in the list). The > rest, i.e. adding the elements that "remap" c-mode to itself, viz.: > (dolist (mode '(c-mode c++-mode c-or-c++-mode)) > (if (and (setq entry (assq mode major-mode-remap-defaults)) > (null (cdr entry))) > (setq major-mode-remap-defaults > (delq entry major-mode-remap-defaults))) > (push (cons mode nil) major-mode-remap-defaults)))) > Can and should stay. (Btw, it is better to use assq-delete-all, > because the above removes only the instances of the first element for > each mode that it finds in the list. Btw, doing so will also avoid > the need to add the 3 entries above, AFAIU.) Can you perhaps suggest another way of protecting CC Mode's symbols in place of the patch which is to be amended/removed? > > I have proposed two ways of fixing the immediate problem, both of them > > simple, easy to review, and easy to test. You have rejected them both. > > It seems it is more important to release Emacs 30 soon that to get it > > right. > We cannot always set everything right when the release is close. What > is being proposed to fix this issue will make things a little bit > better than they were in Emacs 29, and certainly no worse. We will > need to try to find better solutions in Emacs 31. > By contrast the solutions you proposed are much more risky, as they > touch areas that are not directly related to the code which caused the > issue at hand, and because they will have a broader effect. They are > therefore inappropriate for a release branch that is in its 2nd > pretest. Why MUCH more risky? They're a little bit more risky, perhaps. In the time we've been discussing the matter, one of them could have been implemented and now be under review/test. For that matter, the amended patch you're proposing hasn't really been tested either. We know that nobody looked at it or tried it out in the 5½ months from the commit, up until when you looked at it and raised the bug. But we know this patch will have bad effects (see the rest of my posts in this thread). -- Alan Mackenzie (Nuremberg, Germany).