From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#59790: 30.0.50; ns-use-native-fullscreen is not respected for first use of initial-frame-alist Date: Wed, 20 Nov 2024 21:27:09 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29462"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sean@farley.io, 59790@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 20 22:28:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDsFT-0007RN-5M for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Nov 2024 22:28:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDsF4-0002Jf-K6; Wed, 20 Nov 2024 16:28:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDsF0-0002JE-VP for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 16:28:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDsF0-00022V-MP for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 16:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=YyRndQB2gP5nNY/JxZIuhwzog5MKt0YvH8Lhkq1FlXk=; b=kYSIhTINQuQ81SuDFVtAHT4tf3KJ89KB5pjAEAQONrUUM4Kta3cMQAB8+ojLpakVPw2mWfCYzjdHiBdywnSnIL+Ws16PyXEaGn7Axi+xYhIvI62dv0Sec/wnguEaylwTKBcggo1HwrcfBoEwqJinoUsqWsc7J17N/WAy87sVyA0oLZ/D7CI/W6Eo7UtzGLdmAHcIeEO4S72MRsQcwP3G7quQmV7N6HWol/hTaA1dufIPnicpFxSJkgF50mj31SRhwXI/nvD7mJvQRcmmb5k6RcCYvQKAIp5NZdvbBR2KIh+Qk2Nf1/AjiRLDJBWK4v6/GudlGgTvZD2+d2M3Wa2BoQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDsF0-00011t-8T for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 16:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2024 21:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59790 X-GNU-PR-Package: emacs Original-Received: via spool by 59790-submit@debbugs.gnu.org id=B59790.17321380703937 (code B ref 59790); Wed, 20 Nov 2024 21:28:02 +0000 Original-Received: (at 59790) by debbugs.gnu.org; 20 Nov 2024 21:27:50 +0000 Original-Received: from localhost ([127.0.0.1]:47997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDsEo-00011Q-6H for submit@debbugs.gnu.org; Wed, 20 Nov 2024 16:27:50 -0500 Original-Received: from dane.soverin.net ([185.233.34.21]:35337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDsEm-000118-3d for 59790@debbugs.gnu.org; Wed, 20 Nov 2024 16:27:49 -0500 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4XtvZl4nNbzNK; Wed, 20 Nov 2024 21:27:11 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by soverin.net (Postfix) with ESMTPSA id 4XtvZl0rbwzHs; Wed, 20 Nov 2024 21:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1732138031; bh=8rLifcNkUORWn2jjuwfNbai8Yb+rujYFQ0Rzjut7sys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UCKci6F2ElSe25PPLYWOm6ddDoAshddaAiPmkvu7YS6TLgrg3H+SrMR67fU/8KeNx 4UIZ/3v1w874ReMnjbDGN2JbScJAPKisrgstSGjSWeFWbD230fiTVUJh0+/fU2+gkn SOlI5Hy6zkWT9A7mrSt6GHWHV1uCZKhxhIr9xb4TitpAfY696g3rrLDXqlYCGKwNTf /oQeE+R7jDUexAMPOyfrQYNvfsLNh6GQu1d4msznjbIOuZC974mhJfpQte/kouwn+V Ynd3bYWXhaABRHpQXZb4Dq4enG/a4Ata+GWDKGJ1AnVeo8pGfiVwCVIAGLtIlYuBDu u7rlA5Kc5RagQ== Mail-Followup-To: Alan Third , Aaron Jensen , sean@farley.io, 59790@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-Spampanel-Class: ham X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295700 Archived-At: On Sun, Nov 17, 2024 at 12:00:07AM -0500, Aaron Jensen wrote: > ​The bugged behavior is that `ns-use-native-fullscreen' set to nil is not read > when launching emacs. > > > The attached patch should fix this. The problem is that when the frame is > made, the current value of ns-use-native-fullscreen is copied to a variable > and that's only reset when the frame goes from fullscreen to windowed. I > believe the original intent was to ensure that the mode could not change > while the window was fullscreen already. > > This resets the value of fs_is_native if the frame is not already > fullscreen, which allows it to respect the value at the time of the first > fullscreen. > > Without this, the only way to get the behavior that Sean is expecting is to > set ns-use-native-fullscreen in early-init, which should not be necessary. The patch looks good here. The only thing is I get this printed to the console: 2024-11-20 21:11:36.609 emacs[18867:241457] ERROR: Can't have a toolbar in a window with as it's borderview I don't think I've ever seen NextStep explicitly mentioned in macOS code before, other than the "NS" prefix. I'm going to hazard a guess that the first if at the top of createToolbar needs another test for when we're in non-native fullscreen or something. Native fullscreen displays the toolbar, non-native doesn't because it uses the borderless stylemask. Perhaps a check on the stylemask would be enough to cover both this and undecorated. -- Alan Third