From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#73725: Master: Wrong position for byte compiler warning message. Date: Wed, 23 Oct 2024 19:03:02 +0000 Message-ID: References: <8A05D4D2-C77B-4089-B82C-4DB3E88F1276@gmail.com> <26A5812D-9C23-4DB8-8E8D-BD958730AF6C@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16074"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73746@debbugs.gnu.org, acm@muc.de, Stefan Monnier , 73725@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 23 21:04:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3geN-0003sP-IJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Oct 2024 21:04:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3gdr-0007LM-2G; Wed, 23 Oct 2024 15:03:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3gdo-0007L0-Rg for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2024 15:03:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3gdo-0004eA-7K for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2024 15:03:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=From:In-Reply-To:MIME-Version:References:Date:To:Subject; bh=A7tzao4YRWY8KOa9OdbwBGl1hiQI2ff51Qat+tO2rdU=; b=aBrLcSQMHqjfCoWaOMJ4TOAgrgrFCp/Ubom1kL5O4WU3g8znebLKJR5VBl0aVwoUU6MAFtfIN1rSunORsKRdLZUULauAitTX4NUXYCrFe6KwTPLpibFGEjOxgfkWS68abeu/R5XTjLtrEi/7Ex6jXbhkkxqaHju7s69iDOq6lVm9XH6wqdC/1QS/9aDf5+bJN/MGiVBikoUW5Qm/hlxiDZU/5kfQqvtKeJalZv3ZUmk2xOCxiQVSoh1rMdTT8ZAWS5xEJ12ZiMU5BGVGDAxC4sjGiOMJW66CNuUmx8+Vnz2cflYeYX9cQAkkDYFgxxZ8JwICummDzp3QuCUhZkB0YQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3geH-0002pT-NX for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2024 15:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2024 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73725 X-GNU-PR-Package: emacs Original-Received: via spool by 73725-submit@debbugs.gnu.org id=B73725.172971022210834 (code B ref 73725); Wed, 23 Oct 2024 19:04:01 +0000 Original-Received: (at 73725) by debbugs.gnu.org; 23 Oct 2024 19:03:42 +0000 Original-Received: from localhost ([127.0.0.1]:60835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3gdy-0002of-8x for submit@debbugs.gnu.org; Wed, 23 Oct 2024 15:03:42 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:43201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3gdw-0002oO-Ey for 73725@debbugs.gnu.org; Wed, 23 Oct 2024 15:03:41 -0400 Original-Received: (qmail 62353 invoked by uid 3782); 23 Oct 2024 21:03:03 +0200 Original-Received: from muc.de (pd953aa34.dip0.t-ipconnect.de [217.83.170.52]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 23 Oct 2024 21:03:03 +0200 Original-Received: (qmail 1870 invoked by uid 1000); 23 Oct 2024 19:03:03 -0000 Content-Disposition: inline In-Reply-To: <26A5812D-9C23-4DB8-8E8D-BD958730AF6C@gmail.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294155 Archived-At: Hello, Mattias. On Wed, Oct 23, 2024 at 19:49:13 +0200, Mattias Engdegård wrote: > 23 okt. 2024 kl. 13.22 skrev Alan Mackenzie : > > I've incorporated your (Stafan's) suggestions from yesterday into > > the code. See the patch below. > Thank you, I'll try to get some time to look at it -- a couple of > quick notes: > - Isn't the code mutating the return value of a macro? I may be > mistaken but surely it could be a constant. Not really. It's preserving a label on the code between the source and the code generated by the macro. It has no effect whatsoever on the code generated. It merely records the source position for the display of warning and error messages. Whether that label is regarded as part of the "value" seems to be rather an academic question. > - The unknown free variable warning which was the motivation of this > issue should really be moved from codegen to the frontend (ie, cconv > at present). Unless someone can think of a reason why it couldn't (I > can't). That seems unrelated to the two bugs here. Regardless of where the warnings/errors are generated, the correct source file position needs to be attached to the pertinent source form. > Sorry if these were mentioned in your discussion; I haven't read it > through yet. -- Alan Mackenzie (Nuremberg, Germany).