unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: 73746@debbugs.gnu.org, acm@muc.de,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	73725@debbugs.gnu.org
Subject: bug#73725: Master: Wrong position for byte compiler warning message.
Date: Wed, 23 Oct 2024 19:03:02 +0000	[thread overview]
Message-ID: <ZxlIZndsmmQdWknZ@MAC.fritz.box> (raw)
In-Reply-To: <26A5812D-9C23-4DB8-8E8D-BD958730AF6C@gmail.com>

Hello, Mattias.

On Wed, Oct 23, 2024 at 19:49:13 +0200, Mattias Engdegård wrote:
> 23 okt. 2024 kl. 13.22 skrev Alan Mackenzie <acm@muc.de>:

> > I've incorporated your (Stafan's) suggestions from yesterday into
> > the code.  See the patch below.

> Thank you, I'll try to get some time to look at it -- a couple of
> quick notes:

> - Isn't the code mutating the return value of a macro? I may be
> mistaken but surely it could be a constant.

Not really.  It's preserving a label on the code between the source and
the code generated by the macro.  It has no effect whatsoever on the
code generated.  It merely records the source position for the display
of warning and error messages.

Whether that label is regarded as part of the "value" seems to be rather
an academic question.

> - The unknown free variable warning which was the motivation of this
> issue should really be moved from codegen to the frontend (ie, cconv
> at present). Unless someone can think of a reason why it couldn't (I
> can't).

That seems unrelated to the two bugs here.  Regardless of where the
warnings/errors are generated, the correct source file position needs to
be attached to the pertinent source form.

> Sorry if these were mentioned in your discussion; I haven't read it
> through yet.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2024-10-23 19:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10 10:22 bug#73725: Master: Wrong position for byte compiler warning message Alan Mackenzie
2024-10-11 23:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 10:47   ` Alan Mackenzie
2024-10-12 13:53     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 12:01   ` Mattias Engdegård
2024-10-20 14:13     ` Alan Mackenzie
2024-10-20 15:06       ` Mattias Engdegård
2024-10-20 15:38         ` bug#73746: " Alan Mackenzie
2024-10-20 16:35       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-22 12:48         ` Alan Mackenzie
2024-10-22 13:33           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-22 21:19             ` Alan Mackenzie
2024-10-23 13:30               ` bug#73746: " Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-23 11:22             ` Alan Mackenzie
2024-10-23 13:27               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-23 17:44                 ` Alan Mackenzie
2024-10-23 17:49               ` Mattias Engdegård
2024-10-23 19:03                 ` Alan Mackenzie [this message]
2024-10-13 15:31   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxlIZndsmmQdWknZ@MAC.fritz.box \
    --to=acm@muc.de \
    --cc=73725@debbugs.gnu.org \
    --cc=73746@debbugs.gnu.org \
    --cc=mattias.engdegard@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).