From: Thomas Klausner <wiz@gatalith.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73307@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#73307: Fix ctype(3) usage
Date: Tue, 17 Sep 2024 13:55:59 +0200 [thread overview]
Message-ID: <ZuluT_k-VE0LgTWK@exadelic.gatalith.at> (raw)
In-Reply-To: <86r09ibiq3.fsf@gnu.org>
On Tue, Sep 17, 2024 at 02:52:20PM +0300, Eli Zaretskii wrote:
> Thanks. However, I'm not sure this is the right fix, the function is
> defined with argument type of 'int'. Paul, any comments?
That is exactly the problem.
If you pass a 'signed char' below -1, it gets converted to the same
integer value, also a negative number below -1, and you end up passing
an invalid argument to the function. The function is defined to only
accept EOF and non-negative values in the range of 'unsigned char'.
-1 is only special because that's usually the value of EOF.
Thomas
next prev parent reply other threads:[~2024-09-17 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 21:25 bug#73307: Fix ctype(3) usage Thomas Klausner
2024-09-17 11:52 ` Eli Zaretskii
2024-09-17 11:55 ` Thomas Klausner [this message]
2024-09-18 0:05 ` Paul Eggert
2024-09-18 2:13 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-18 11:45 ` Eli Zaretskii
2024-09-18 15:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-18 15:35 ` Paul Eggert
2024-09-18 16:11 ` Eli Zaretskii
2024-09-18 16:22 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuluT_k-VE0LgTWK@exadelic.gatalith.at \
--to=wiz@gatalith.at \
--cc=73307@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).