From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Date: Fri, 5 Jul 2024 19:55:19 +0000 Message-ID: References: <87sewo5vym.fsf@web.de> <87zfqwh1gb.fsf@web.de> <86o77c75jd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33734"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , acm@muc.de, Eli Zaretskii , Andrea Corallo , 71934@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 05 21:56:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPp2f-0008dS-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jul 2024 21:56:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPp2H-000670-Fa; Fri, 05 Jul 2024 15:56:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPp2F-00066j-Cn for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 15:55:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPp2F-0003tJ-4D for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 15:55:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPp2H-0001KS-VS for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 15:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2024 19:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71934 X-GNU-PR-Package: emacs Original-Received: via spool by 71934-submit@debbugs.gnu.org id=B71934.17202093345059 (code B ref 71934); Fri, 05 Jul 2024 19:56:01 +0000 Original-Received: (at 71934) by debbugs.gnu.org; 5 Jul 2024 19:55:34 +0000 Original-Received: from localhost ([127.0.0.1]:45075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPp1q-0001JX-5p for submit@debbugs.gnu.org; Fri, 05 Jul 2024 15:55:34 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:62555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPp1o-0001JG-Ps for 71934@debbugs.gnu.org; Fri, 05 Jul 2024 15:55:33 -0400 Original-Received: (qmail 85049 invoked by uid 3782); 5 Jul 2024 21:55:21 +0200 Original-Received: from muc.de (pd953a1ab.dip0.t-ipconnect.de [217.83.161.171]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 05 Jul 2024 21:55:20 +0200 Original-Received: (qmail 28079 invoked by uid 1000); 5 Jul 2024 19:55:19 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288435 Archived-At: Hello, Stefan. On Fri, Jul 05, 2024 at 14:17:38 -0400, Stefan Monnier wrote: > > Not sure what you mean by "no such thing as a form ... like a closure". > A form that starts with `closure` is not a valid form because there is > no definition for `closure`: (fboundp 'closure) => nil. > > I bumped into one last summer. > > In particular (in my development repo fixing bug #64646) I put this into > > *scratch*: > > (defconst foo (lambda (baz) (car baz))) > > , evaluated it with C-x C-e and then M-: (native-compile foo). This > > threw the error "Cannot native-compile, form is not a lambda". > That error seems right according to the docstring: > (defun native-compile (function-or-file &optional output) > "Compile FUNCTION-OR-FILE into native code. > This is the synchronous entry-point for the Emacs Lisp native > compiler. FUNCTION-OR-FILE is a function symbol, a form, or the > filename of an Emacs Lisp source file. If OUTPUT is non-nil, use > it as the filename for the compiled object. If FUNCTION-OR-FILE > is a filename, if the compilation was successful return the > filename of the compiled object. If FUNCTION-OR-FILE is a > function symbol or a form, if the compilation was successful > return the compiled function." > (closure ...) is not a function symbol nor a valid form. Instead it's > a function value and the docstring doesn't say such are > a valid arguments to `native-compile`. All very clever arguments, no doubt, but in the end it means you cannot native compile foo. I've just tried it on emacs-30, and it doesn't work. But you could compile foo last summer after my fixes for bug #64646. Between last summer and now, something has gone badly wrong in Emacs's basic mechanisms. > Admittedly, maybe we should extend `native-compile` to accept function > values, just like `byte-compile`. Or something like that, yes. But if logical combinations of terms like "form", "closure", "function value", "valid form" lead to not being able to compile foo, then I suggest that these terms and their applicability might need to be thought through somewhat. [ .... ] > > So I fixed > > comp--spill-lap-function (form version) so as to compile that form. > Why `comp--spill-lap-function` specifically (instead of > `native-compile`, for example)? I fixed what was wrong at the time. > > I've no idea how Emacs would handle that defconst now. > Hmm... AFAICT your example doesn't relate to `defconst`. > You'd get the same result with > M-: (native-compile (lambda (baz) (car baz))) RET Whatever. foo doesn't compile; that should be fixed. > - Stefan -- Alan Mackenzie (Nuremberg, Germany).