From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Date: Mon, 27 May 2024 15:28:21 +0000 Message-ID: References: <87ikz0xrew.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11095"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 71178@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 27 17:29:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBcHb-0002gA-3D for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 May 2024 17:29:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBcHR-00079y-6g; Mon, 27 May 2024 11:28:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBcHN-00079O-9s for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 11:28:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBcHN-0001yn-0z for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 11:28:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBcHV-0001xL-PD for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 11:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2024 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs Original-Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.17168237217488 (code B ref 71178); Mon, 27 May 2024 15:29:01 +0000 Original-Received: (at 71178) by debbugs.gnu.org; 27 May 2024 15:28:41 +0000 Original-Received: from localhost ([127.0.0.1]:45068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBcHA-0001wh-O3 for submit@debbugs.gnu.org; Mon, 27 May 2024 11:28:41 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:60356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBcH8-0001wU-EG for 71178@debbugs.gnu.org; Mon, 27 May 2024 11:28:39 -0400 Original-Received: (qmail 28773 invoked by uid 3782); 27 May 2024 17:28:23 +0200 Original-Received: from muc.de (p4fe150ab.dip0.t-ipconnect.de [79.225.80.171]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 27 May 2024 17:28:22 +0200 Original-Received: (qmail 21390 invoked by uid 1000); 27 May 2024 15:28:21 -0000 Content-Disposition: inline In-Reply-To: <87ikz0xrew.fsf@neverwas.me> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286048 Archived-At: Hello, JP. On Sun, May 26, 2024 at 13:13:43 -0700, J.P. wrote: > Hi Alan, > Alan Mackenzie writes: > > Hello, Stefan and Emacs. > > In my development branch, based on master, last updated ~March 2024. > > (i) Build emacs. > > (ii) make -j17 check. > > The ert session this starts goes well, apart from in > > lisp/erc/erc-tests.el. This gets aborted by ert after 62 from 92 tests > > have passed. Test 63 fails for known reasons, a mismatch of two strings > > compared with `equal'. > > The log file, erc-tests.log, looks like this around the output for test > > 63: > > ......................................................... > > passed 60/92 erc--update-user-modes (0.000093 sec) > > passed 61/92 erc--user-modes (0.000053 sec) > > passed 62/92 erc--valid-local-channel-p (0.000071 sec) > > Test erc--with-dependent-type-match backtrace: > > Aborted: Ran 92 tests, 62 results as expected, 1 unexpected (2024-05-24 > > 15:26:55+0000, 2.791555 sec) > > 1 unexpected results: > > FAILED erc--with-dependent-type-match > > UNKNOWN erc--with-entrypoint-environment > > UNKNOWN erc-channel-p > > UNKNOWN erc-channel-user > I'm afraid I must claim this as my own handiwork. My apologies. Thanks! But I think that erc--restore-initialize-priors has triggered the error rather than containing the error itself. I don't really think you should be apologising for this. ;-) > > ........................................................ > > Note that > > (i) No error message or backtrace gets printed for test 63. This is a > > bug. > > (ii) The test run gets aborted. This shouldn't happen, and is a bug. > Yes, this is unfortunate. > > erc-tests.el runs satisfactorally in an Emacs session, started by M-x > > ert, and accepting the default selection t. > It seems you have identified the underlying cause: > https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01140.html I've been looking at lisp/emacs-lisp/ert.el, and I think that suppressing the debug output (or rather, not invoking a backtrace dump in batch mode) is where the problem lies. However, when I enabled these in my own copy, they produced an erc.log of over 100 MB. But that was in my customised Emacs where I've changed quite a few things always to get a complete backtrace. So I'm not sure what is best, here. > The test itself is of minimal utility and is therefore rubbish (if not > outright vandalism), so I will remove it unless you'd rather it stick > around until the conversation on the list gets going. I think I'd rather the test should stay there a bit longer. It highlights problems in pcase.el and ert.el which might get fixed sooner if the test is still there. _MIGHT_ (here's hoping!). > Thanks, > J.P. -- Alan Mackenzie (Nuremberg, Germany).