From: Alan Mackenzie <acm@muc.de>
To: "J.P." <jp@neverwas.me>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 71178@debbugs.gnu.org
Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why.
Date: Mon, 27 May 2024 15:28:21 +0000 [thread overview]
Message-ID: <ZlSmlVuv0lE8Upnv@ACM> (raw)
In-Reply-To: <87ikz0xrew.fsf@neverwas.me>
Hello, JP.
On Sun, May 26, 2024 at 13:13:43 -0700, J.P. wrote:
> Hi Alan,
> Alan Mackenzie <acm@muc.de> writes:
> > Hello, Stefan and Emacs.
> > In my development branch, based on master, last updated ~March 2024.
> > (i) Build emacs.
> > (ii) make -j17 check.
> > The ert session this starts goes well, apart from in
> > lisp/erc/erc-tests.el. This gets aborted by ert after 62 from 92 tests
> > have passed. Test 63 fails for known reasons, a mismatch of two strings
> > compared with `equal'.
> > The log file, erc-tests.log, looks like this around the output for test
> > 63:
> > .........................................................
> > passed 60/92 erc--update-user-modes (0.000093 sec)
> > passed 61/92 erc--user-modes (0.000053 sec)
> > passed 62/92 erc--valid-local-channel-p (0.000071 sec)
> > Test erc--with-dependent-type-match backtrace:
> > Aborted: Ran 92 tests, 62 results as expected, 1 unexpected (2024-05-24
> > 15:26:55+0000, 2.791555 sec)
> > 1 unexpected results:
> > FAILED erc--with-dependent-type-match
> > UNKNOWN erc--with-entrypoint-environment
> > UNKNOWN erc-channel-p
> > UNKNOWN erc-channel-user
> I'm afraid I must claim this as my own handiwork. My apologies.
Thanks! But I think that erc--restore-initialize-priors has triggered
the error rather than containing the error itself. I don't really think
you should be apologising for this. ;-)
> > ........................................................
> > Note that
> > (i) No error message or backtrace gets printed for test 63. This is a
> > bug.
> > (ii) The test run gets aborted. This shouldn't happen, and is a bug.
> Yes, this is unfortunate.
> > erc-tests.el runs satisfactorally in an Emacs session, started by M-x
> > ert, and accepting the default selection t.
> It seems you have identified the underlying cause:
> https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01140.html
I've been looking at lisp/emacs-lisp/ert.el, and I think that suppressing
the debug output (or rather, not invoking a backtrace dump in batch mode)
is where the problem lies. However, when I enabled these in my own copy,
they produced an erc.log of over 100 MB. But that was in my customised
Emacs where I've changed quite a few things always to get a complete
backtrace. So I'm not sure what is best, here.
> The test itself is of minimal utility and is therefore rubbish (if not
> outright vandalism), so I will remove it unless you'd rather it stick
> around until the conversation on the list gets going.
I think I'd rather the test should stay there a bit longer. It
highlights problems in pcase.el and ert.el which might get fixed sooner
if the test is still there. _MIGHT_ (here's hoping!).
> Thanks,
> J.P.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2024-05-27 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 19:23 bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why Alan Mackenzie
2024-05-26 20:13 ` J.P.
2024-05-27 15:28 ` Alan Mackenzie [this message]
2024-05-28 13:33 ` J.P.
2024-06-05 22:13 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlSmlVuv0lE8Upnv@ACM \
--to=acm@muc.de \
--cc=71178@debbugs.gnu.org \
--cc=jp@neverwas.me \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).