From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#70435: 30.0.50; cc-mode: <> are sometimes not reconized as parentheses Date: Thu, 2 May 2024 10:24:23 +0000 Message-ID: References: <87le5cuuyq.fsf@gmail.com> <87y18xifpb.fsf@gmail.com> <87sez4uleo.fsf@gmail.com> <8634r0muh3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70435@debbugs.gnu.org To: Eli Zaretskii , =?UTF-8?Q?G=C3=A9za?= Herman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 02 12:24:50 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2TcQ-0000wu-4b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 May 2024 12:24:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2TcJ-00051L-Rs; Thu, 02 May 2024 06:24:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2TcH-0004yr-5r for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 06:24:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2TcG-0005pK-UE for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 06:24:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2Tcc-0006eo-Jx for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 06:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2024 10:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70435 X-GNU-PR-Package: emacs Original-Received: via spool by 70435-submit@debbugs.gnu.org id=B70435.171464549725581 (code B ref 70435); Thu, 02 May 2024 10:25:02 +0000 Original-Received: (at 70435) by debbugs.gnu.org; 2 May 2024 10:24:57 +0000 Original-Received: from localhost ([127.0.0.1]:42899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2TcW-0006eX-RY for submit@debbugs.gnu.org; Thu, 02 May 2024 06:24:57 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:18753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2TcV-0006eR-Fw for 70435@debbugs.gnu.org; Thu, 02 May 2024 06:24:56 -0400 Original-Received: (qmail 11469 invoked by uid 3782); 2 May 2024 12:24:27 +0200 Original-Received: from muc.de (p4fe15d0d.dip0.t-ipconnect.de [79.225.93.13]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 02 May 2024 12:24:27 +0200 Original-Received: (qmail 9589 invoked by uid 1000); 2 May 2024 10:24:23 -0000 Content-Disposition: inline In-Reply-To: <8634r0muh3.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284303 Archived-At: Hello, Eli and Géza. On Thu, May 02, 2024 at 12:30:32 +0300, Eli Zaretskii wrote: > > From: Herman, Géza > > Cc: Herman Géza , > > 70435@debbugs.gnu.org, Eli > > Zaretskii > > Date: Mon, 29 Apr 2024 19:21:01 +0200 > > Hello Alan, > > Alan Mackenzie writes: > > > I have a fix, I think. It is actually a two line fix, removing > > > a test > > > from the top of a function, but it involves reindenting the > > > entire rest > > > of the function. > > > Please apply the patch below, recompile cc-engine.el, then load > > > the > > > resulting CC Mode into a running Emacs. Please test it on your > > > real C++ > > > code, and let me know if the bug is actually fixed. Thanks! > > I can confirm that the patch fixes the issue, I tested it in real > > circumstances. > > Thanks for fixing the problem so quickly! > Alan, should this bug be closed now? Apologies for my dithering. I've been having second thoughts about the patch in the last few days, and wondering whether I should refine it. It's all to do with a function c-unmark-<>-around-region, which was run in before-change-functions for a deletion, and after-change-functions for an insertion. The patch I sent to Géza made that function run in before- and after-c-f both for insertions and deletions. I've been wondering whether that is strictly necessary, since it will slow down CC Mode a little. I'm thinking that in the insertion/before-c-f case, I might not need the call. Géza, would you be prepared to do a little more testing if I modified the patch? -- Alan Mackenzie (Nuremberg, Germany).