From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#69684: Functionality of Fbare_symbol has been lost. Date: Mon, 11 Mar 2024 20:01:06 +0000 Message-ID: References: <86r0giwrw9.fsf@gnu.org> <867ciawetg.fsf@gnu.org> <36c94f0a-3a1a-407d-9cef-40a5e8cc35af@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26575"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, Eli Zaretskii , 69684@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 11 21:02:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjlqk-0006jL-0c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Mar 2024 21:02:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjlqP-0001p2-Af; Mon, 11 Mar 2024 16:01:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjlpw-0001dU-68 for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 16:01:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjlpv-0000wh-T7 for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 16:01:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjlqT-0006ts-Su for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2024 16:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Mar 2024 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69684 X-GNU-PR-Package: emacs Original-Received: via spool by 69684-submit@debbugs.gnu.org id=B69684.171018731426511 (code B ref 69684); Mon, 11 Mar 2024 20:02:01 +0000 Original-Received: (at 69684) by debbugs.gnu.org; 11 Mar 2024 20:01:54 +0000 Original-Received: from localhost ([127.0.0.1]:41346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjlqM-0006tW-7p for submit@debbugs.gnu.org; Mon, 11 Mar 2024 16:01:54 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:19825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjlqH-0006tC-QC for 69684@debbugs.gnu.org; Mon, 11 Mar 2024 16:01:52 -0400 Original-Received: (qmail 66074 invoked by uid 3782); 11 Mar 2024 21:01:10 +0100 Original-Received: from acm.muc.de (p4fe15834.dip0.t-ipconnect.de [79.225.88.52]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 11 Mar 2024 21:01:09 +0100 Original-Received: (qmail 11660 invoked by uid 1000); 11 Mar 2024 20:01:06 -0000 Content-Disposition: inline In-Reply-To: <36c94f0a-3a1a-407d-9cef-40a5e8cc35af@cs.ucla.edu> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281492 Archived-At: Hello Paul. On Mon, Mar 11, 2024 at 00:38:39 -0700, Paul Eggert wrote: > On 2024-03-10 03:39, Eli Zaretskii wrote: > > OK, so let's wait for Paul to chime in. > The problem was that I mistakenly believed the documentation when it > said that a symbol with position behaves like its bare symbol when > symbols-with-position-enabled is t. Unfortunately it appears that this > part of the doc wasn't intended to apply to bare-symbol, so when I fixed > something else involving bare-symbol I got the semantics wrong. I think the doc and doc strings were somewhat unclear when it came to the less obvious cases. > As penance I installed the attached, which makes a simple code change > along the lines that you suggested and adds a regression test to help > prevent this bug from happening again. Thanks! > The hardest part of writing this patch was adjusting the documentation > to match what I think was the intent of the behavior. Alan, if you find > mistakes in that please let me know. That might take a little tine. I've broken my right arm, which makes doing Emacs strenuous work. But I'm sure the patch will work. It's also worth pointing out that the uses of SWPs are expanding (see bug #67455), something I've got mixed feelings about, even though I'm doing the implementation. > A couple of other things. > Currently (position-symbol 'x -1) creates a symbol with position where > the position is negative; is that intended? The documentation says > positions are nonnegative. Yes. I think that back when it was being done, there was no convenient way to exclude -ve numbers. > Also, more test cases of the symbols with position primitives would not > go amiss. I'm not a good person to write them, though, as I easily get > confused by symbols with position. Yes, I agree here, too. [ .... ] -- Alan Mackenzie (Nuremberg, Germany)