From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65116: 29.1; query-replace-read-args fails reading second arg in detached minibuf Date: Sun, 14 Jan 2024 14:14:37 +0000 Message-ID: References: <831qalivwr.fsf@gnu.org> <87o7do21zv.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25301"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, Eli Zaretskii , jim@rees.org, 65116@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 14 15:15:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rP1Gl-0006Nx-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Jan 2024 15:15:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rP1GT-0001cq-U2; Sun, 14 Jan 2024 09:15:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rP1GS-0001cY-5p for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 09:15:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rP1GR-00062N-TD for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 09:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rP1GR-0007qO-2W for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 09:15:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jan 2024 14:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65116 X-GNU-PR-Package: emacs Original-Received: via spool by 65116-submit@debbugs.gnu.org id=B65116.170524168529933 (code B ref 65116); Sun, 14 Jan 2024 14:15:03 +0000 Original-Received: (at 65116) by debbugs.gnu.org; 14 Jan 2024 14:14:45 +0000 Original-Received: from localhost ([127.0.0.1]:41955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rP1G9-0007mi-B4 for submit@debbugs.gnu.org; Sun, 14 Jan 2024 09:14:45 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:25852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rP1G8-0007mU-1s for 65116@debbugs.gnu.org; Sun, 14 Jan 2024 09:14:44 -0500 Original-Received: (qmail 11894 invoked by uid 3782); 14 Jan 2024 15:14:38 +0100 Original-Received: from acm.muc.de (pd953ae63.dip0.t-ipconnect.de [217.83.174.99]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 14 Jan 2024 15:14:38 +0100 Original-Received: (qmail 24619 invoked by uid 1000); 14 Jan 2024 14:14:37 -0000 Content-Disposition: inline In-Reply-To: <87o7do21zv.fsf@yahoo.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278213 Archived-At: Hello, Po. On Sun, Jan 14, 2024 at 08:27:16 +0800, Po Lu wrote: > Eli Zaretskii writes: > >> Date: Fri, 12 Jan 2024 21:44:11 +0000 > >> Cc: 65116@debbugs.gnu.org, Eli Zaretskii , acm@muc.de > >> From: Alan Mackenzie > >> Hello, Jim. > >> On Fri, Jan 12, 2024 at 12:57:42 -0600, Jim Rees wrote: > >> > Well that's a relief. I do have an unusual setup with detached minibuf and > >> > focus follows mouse. There has been a lot of churn in replace.el and frame.c > >> > lately and I keep hoping the bug will go away on its own. I don't really > >> > understand all the focus changes in the code but I do see why they are > >> > necessary. > >> > I have a workaround, I have bound this to a key and use it to re-focus to > >> > the minibuf so I can enter the 'to' text: > >> > (select-frame-set-input-focus (window-frame (minibuffer-window))) > >> > But that requires manual intervention so for now I'm sticking with 28.1. > >> I've been playing with the setup for an hour or two. It seems that > >> performing some action in the minibuffer (say, M-x auto-revert-mode, but > >> anything will do) causes M-% to work properly. But then, the moment the > >> mouse leaves the active frame or window (I'm not sure which), M-% no > >> longer works properly, until the next minibuffer action. > >> I know this isn't much help to you, but it should be a help to us, > >> tracking down what's going wrong. > > If this is WM-specific, maybe Po Lu (CC'ed) could help us understand > > what happens here? Perhaps some message we expect from X is not being > > received in this scenario? > This is GTK3-specific. I've installed a fix on master, please test. Thanks for this. Thanks also for the detailed comment explaining the fix. I now understand where and why the redirected focus carefully installed on the main frame was being removed. I've tested it, with Jim's test case, and it works for me. -- Alan Mackenzie (Nuremberg, Germany).