unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: "Gerd Möllmann" <gerd.moellmann@gmail.com>,
	acm@muc.de, "Eli Zaretskii" <eliz@gnu.org>,
	68200-done@debbugs.gnu.org
Subject: bug#68200: File local byte-compile-dynamic-docstrings:nil ignored (was: bug#68200: 30.0.50; Emacs reloads init file when calling `documentation')
Date: Thu, 11 Jan 2024 17:59:34 +0000	[thread overview]
Message-ID: <ZaAshrGRCoopKXXR@ACM> (raw)
In-Reply-To: <87sf35j28v.fsf_-_@web.de>

Hello, Michael.

On Wed, Jan 10, 2024 at 04:28:32 +0100, Michael Heerdegen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > You've almost certainly written your own patch for it by now, but
> > nevertheless, could I ask you to try out this patch.  I don't have a
> > convenient test case here.

> > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> > index 2bc8d54ba77..ad8d53d01e9 100644
> > --- a/lisp/emacs-lisp/bytecomp.el
> > +++ b/lisp/emacs-lisp/bytecomp.el
> > @@ -2605,9 +2605,10 @@ byte-compile-output-docform
> >  `defvaralias', `autoload' and `custom-declare-variable' need that."
> >    ;; We need to examine byte-compile-dynamic-docstrings
> >    ;; in the input buffer (now current), not in the output buffer.
> > -  (let ((byte-compile-dynamic-docstrings byte-compile-dynamic-docstrings))
> > +  (let ((dynamic-docstrings byte-compile-dynamic-docstrings))
> >      (with-current-buffer byte-compile--outbuffer
> > -      (let ((position (point))
> > +      (let ((byte-compile-dynamic-docstrings dynamic-docstrings)
> > +            (position (point))

> Yes, that's what I tried as well.  This approach seems to fix this
> problem here, so: fine by me.

OK, I've committed the fix and I'm closing the bug with this post.

> Thanks,

> Michael.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2024-01-11 17:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02  1:53 bug#68200: 30.0.50; Emacs reloads init file when calling `documentation' Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02  2:33 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 13:09 ` Eli Zaretskii
2024-01-07  1:40   ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-07  5:43     ` Gerd Möllmann
2024-01-07  7:33       ` Eli Zaretskii
2024-01-07 17:20         ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-07 17:33         ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 21:22           ` Alan Mackenzie
2024-01-08 23:09             ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 11:26               ` Alan Mackenzie
2024-01-10  3:28                 ` bug#68200: File local byte-compile-dynamic-docstrings:nil ignored (was: bug#68200: 30.0.50; Emacs reloads init file when calling `documentation') Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 17:59                   ` Alan Mackenzie [this message]
2024-01-09 12:36             ` bug#68200: 30.0.50; Emacs reloads init file when calling `documentation' Eli Zaretskii
2024-01-11 18:10               ` Alan Mackenzie
2024-01-11 19:22                 ` Eli Zaretskii
2024-01-11 19:40                   ` Alan Mackenzie
2024-01-11 19:54             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaAshrGRCoopKXXR@ACM \
    --to=acm@muc.de \
    --cc=68200-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=gerd.moellmann@gmail.com \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).