From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#68200: 30.0.50; Emacs reloads init file when calling `documentation' Date: Tue, 9 Jan 2024 11:26:52 +0000 Message-ID: References: <8734vgjya9.fsf@web.de> <83wmsrzxtk.fsf@gnu.org> <875y056hvj.fsf@web.de> <8334v9simj.fsf@gnu.org> <877ckloxos.fsf@web.de> <87sf375snq.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1767"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= , acm@muc.de, Eli Zaretskii , 68200@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 12:28:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNAHM-0000GS-2X for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 12:28:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNAGz-00020Z-DQ; Tue, 09 Jan 2024 06:27:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNAGx-00020P-Nt for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 06:27:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNAGx-0005uO-En for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 06:27:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNAH4-0007iL-68 for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 06:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 11:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68200 X-GNU-PR-Package: emacs Original-Received: via spool by 68200-submit@debbugs.gnu.org id=B68200.170479962929588 (code B ref 68200); Tue, 09 Jan 2024 11:28:02 +0000 Original-Received: (at 68200) by debbugs.gnu.org; 9 Jan 2024 11:27:09 +0000 Original-Received: from localhost ([127.0.0.1]:38504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNAGD-0007h9-9P for submit@debbugs.gnu.org; Tue, 09 Jan 2024 06:27:09 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:45486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNAGA-0007ge-Pj for 68200@debbugs.gnu.org; Tue, 09 Jan 2024 06:27:07 -0500 Original-Received: (qmail 70907 invoked by uid 3782); 9 Jan 2024 12:26:53 +0100 Original-Received: from acm.muc.de (p4fe15193.dip0.t-ipconnect.de [79.225.81.147]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 09 Jan 2024 12:26:52 +0100 Original-Received: (qmail 6983 invoked by uid 1000); 9 Jan 2024 11:26:52 -0000 Content-Disposition: inline In-Reply-To: <87sf375snq.fsf@web.de> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277620 Archived-At: Hello, Michael. On Tue, Jan 09, 2024 at 00:09:29 +0100, Michael Heerdegen wrote: > Alan Mackenzie writes: > > And I'll have a look at why that variable no longer appears to be > > working (though I have rather a lot on in the next few days). > The let-binding of `byte-compile-output-docform' your commit adds in > `byte-compile-output-docform' - you are aware that in my case this > rebinds the buffer local variable before switching to a > different buffer where this binding is not visible? Ah. I've always been a bit vague about mixing buffer local bindings with let bindings. Thanks for spotting the cause of the bug. You've almost certainly written your own patch for it by now, but nevertheless, could I ask you to try out this patch. I don't have a convenient test case here. diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 2bc8d54ba77..ad8d53d01e9 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -2605,9 +2605,10 @@ byte-compile-output-docform `defvaralias', `autoload' and `custom-declare-variable' need that." ;; We need to examine byte-compile-dynamic-docstrings ;; in the input buffer (now current), not in the output buffer. - (let ((byte-compile-dynamic-docstrings byte-compile-dynamic-docstrings)) + (let ((dynamic-docstrings byte-compile-dynamic-docstrings)) (with-current-buffer byte-compile--outbuffer - (let ((position (point)) + (let ((byte-compile-dynamic-docstrings dynamic-docstrings) + (position (point)) (print-continuous-numbering t) print-number-table ;; FIXME: The bindings below are only needed for when we're Thanks! > Michael. -- Alan Mackenzie (Nuremberg, Germany).