From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#67196: M-: uses a wrong value of debug-on-error when it is nil. Date: Sat, 25 Nov 2023 14:14:59 +0000 Message-ID: References: <83ttpbdm2f.fsf@gnu.org> <83il5qe00e.fsf@gnu.org> <83edgecce4.fsf@gnu.org> <8334wuc7cn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17787"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67196@debbugs.gnu.org, acm@muc.de, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 15:16:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6tSA-0004TC-Uf for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 15:16:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6tRv-0001Of-4e; Sat, 25 Nov 2023 09:15:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6tRs-0001O7-Tj for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 09:15:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6tRs-00039c-LU for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 09:15:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6tRx-0000mR-No for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 09:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 14:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67196 X-GNU-PR-Package: emacs Original-Received: via spool by 67196-submit@debbugs.gnu.org id=B67196.17009217132938 (code B ref 67196); Sat, 25 Nov 2023 14:16:01 +0000 Original-Received: (at 67196) by debbugs.gnu.org; 25 Nov 2023 14:15:13 +0000 Original-Received: from localhost ([127.0.0.1]:38218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6tRB-0000lK-A8 for submit@debbugs.gnu.org; Sat, 25 Nov 2023 09:15:13 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:16899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6tR9-0000l8-21 for 67196@debbugs.gnu.org; Sat, 25 Nov 2023 09:15:11 -0500 Original-Received: (qmail 74162 invoked by uid 3782); 25 Nov 2023 15:14:59 +0100 Original-Received: from acm.muc.de (pd953a2e3.dip0.t-ipconnect.de [217.83.162.227]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 25 Nov 2023 15:14:59 +0100 Original-Received: (qmail 18445 invoked by uid 1000); 25 Nov 2023 14:14:59 -0000 Content-Disposition: inline In-Reply-To: <8334wuc7cn.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274980 Archived-At: Hello, Eli. On Sat, Nov 25, 2023 at 15:04:08 +0200, Eli Zaretskii wrote: > > Date: Sat, 25 Nov 2023 12:40:03 +0000 > > Cc: monnier@iro.umontreal.ca, 67196@debbugs.gnu.org, acm@muc.de > > From: Alan Mackenzie [ .... ] > > > Note that (AFAIU) your change doesn't just solve the problem you > > > bumped into, it also changes the value of debug-on-error inside > > > eval-expression etc., when eval-expression-debug-on-error's value is > > > non-nil, but not t. I wonder what is the reason for that? > > I don't see that in my current version of the patch (below). To test > > this, I used the following: > > (defun foo () > > (interactive) > > (message "debug-on-error is %s" debug-on-error) > > (message "eval-expression-debug-on-error is %s" eval-expression-debug-on-error) > > (car 'foo)) > > , and called it with various settings of debug-on-error and > > eval-expression-debug-on-error. In particular, with > > (setq eval-expression-debug-on-error '(wrong-type-argument)) > > , I still see debug-on-error reported as nil. > No, I meant with the current code debug-on-error is set to t whenever > eval-expression-debug-on-error is non-nil, .... Yes. > .... and your change sets it to the same value as > eval-expression-debug-on-error instead. That is not what is meant to happen. Instead, the new internal variable debug-from--eval-expression gets set to e-e-debug-on-error. debug-on-error should remain unchanged throughout a M-: call, leaving it free for use by user code. The subroutines of signal_or_quit test debug-from--eval-expression in addition to testing debug-on-error. Are you sure that isn't what you're seeing? -- Alan Mackenzie (Nuremberg, Germany).