From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.bugs Subject: bug#67142: 29.1; with-sqlite-transaction commits on exception rather than rolling back Date: Mon, 13 Nov 2023 01:47:01 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mkoGy538Gt7qXCzN" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20539"; mail-complaints-to="usenet@ciao.gmane.io" To: 67142@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 13 01:48:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2L83-000573-SS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Nov 2023 01:48:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2L7q-0001r1-Ns; Sun, 12 Nov 2023 19:48:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2L7m-0001qn-8W for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 19:48:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2L7l-00068g-8O for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 19:48:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2L8Q-0001bs-0t for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 19:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2023 00:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67142 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16998364985918 (code B ref -1); Mon, 13 Nov 2023 00:49:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Nov 2023 00:48:18 +0000 Original-Received: from localhost ([127.0.0.1]:57248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2L7h-0001XJ-AS for submit@debbugs.gnu.org; Sun, 12 Nov 2023 19:48:18 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:43908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2L7c-0001Wv-6u for submit@debbugs.gnu.org; Sun, 12 Nov 2023 19:48:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2L6j-0001jx-Kx for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 19:47:19 -0500 Original-Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1r2L6d-0005wQ-BU for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 19:47:15 -0500 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4ST9jy22xzz9sTt for ; Mon, 13 Nov 2023 01:47:02 +0100 (CET) Content-Disposition: inline X-Rspamd-Queue-Id: 4ST9jy22xzz9sTt Received-SPF: pass client-ip=2001:67c:2050:0:465::202; envelope-from=mail@vasilij.de; helo=mout-p-202.mailbox.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274243 Archived-At: --mkoGy538Gt7qXCzN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable During experimentation with built-in SQLite support, I've noticed that if I use `with-sqlite-transaction' and there is a mistake in the body, `sqlite-commit' is executed rather than `sqlite-rollback', thereby committing the changes done up to the error instead of backing out. This appears to be unusual behavior. From my quick research, the following SQLite bindings in other languages have an equivalent to `with-sqlite-transaction' and back out changes on error: - CHICKEN Scheme: https://api.call-cc.org/5/doc/sql-de-lite#def:with-transaction - Go: https://pkg.go.dev/database/sql#Conn.BeginTx - Racket: https://docs.racket-lang.org/db/query-api.html#%28def._%28%28lib.= _db%2Fbase..rkt%29._call-with-transaction%29%29 - Ruby: https://www.rubydoc.info/gems/sqlite3/1.4.2/SQLite3/Database#transa= ction-instance_method - Rust: https://docs.rs/rusqlite/latest/rusqlite/struct.Connection.html#method.tr= ansaction In languages not offering an equivalent API, it was instead recommended to manually issue BEGIN/COMMIT/ROLLBACK statements. But given that `with-sqlite-transaction' exists, it would be less confusing to make it back out on exception (and re-raise the original error). In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) Windowing system distributor 'The X.Org Foundation', version 11.0.12101009 System Description: Arch Linux Configured using: 'configure --sysconfdir=3D/etc --prefix=3D/usr --libexecdir=3D/usr/lib --with-tree-sitter --localstatedir=3D/var --with-cairo --disable-build-details --with-harfbuzz --with-libsystemd --with-modules --with-x-toolkit=3Dgtk3 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3D2 -Wformat -Werror=3Dformat-security -fstack-clash-protection -fcf-protection -g -ffile-prefix-map=3D/build/emacs/src=3D/usr/src/debug/emacs -flto=3Dauto' 'LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=3Dauto'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_MESSAGES:=20 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 36631 11549) (symbols 48 5153 0) (strings 32 13273 1917) (string-bytes 1 378652) (vectors 16 9346) (vector-slots 8 149327 16481) (floats 8 21 19) (intervals 56 235 0) (buffers 984 10)) --mkoGy538Gt7qXCzN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE0dAcySl3bqM8O17WFmfJg6zCifoFAmVRcgEACgkQFmfJg6zC ifrTOQf7Biv192lViw12PHt8qpZAgVwnh3LtORjzVWTZaf8oQ9mo0NcCmTp87CDt dDZcX0mooXOsCuwNndVNcfFyne03JUQcLYVYO7qDns6pblZ4wZ31CKONT6wCrrq9 AT4QChUp9ykPnuBGtt1+QJkpDqE+wpOjV+ukGTv5lqRPNvrQuRMGztgwG24yekBs x2MQEjSarkEhJnrlj7L3efvPOFgSQVd7Zuw9Xu1DsBNTSY+l/1HmpDONtsA2DReL b52L9nMjVIUnAxJTWTobt4gCDnJc59xEMnWRZNFjf2Pg64ObKOp1MTz2Kml0yVBH 7kflgHLalZyuXKHGdNPsC3qXNTD8ZQ== =i3bl -----END PGP SIGNATURE----- --mkoGy538Gt7qXCzN--