From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#66991: Confusion in interactive-form with commands with bare interactive forms. Date: Wed, 8 Nov 2023 08:56:42 +0000 Message-ID: References: <83wmut1pb1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1792"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 66991@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 08 09:57:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0eNk-0000Ko-9z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Nov 2023 09:57:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0eNJ-0005N6-Di; Wed, 08 Nov 2023 03:57:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0eNI-0005Mq-7C for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:57:24 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0eNH-0000gN-Ut for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:57:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0eNu-0002Hk-Bc for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2023 08:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66991 X-GNU-PR-Package: emacs Original-Received: via spool by 66991-submit@debbugs.gnu.org id=B66991.16994338518743 (code B ref 66991); Wed, 08 Nov 2023 08:58:02 +0000 Original-Received: (at 66991) by debbugs.gnu.org; 8 Nov 2023 08:57:31 +0000 Original-Received: from localhost ([127.0.0.1]:43986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0eNO-0002Gw-P8 for submit@debbugs.gnu.org; Wed, 08 Nov 2023 03:57:31 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:60935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0eNM-0002Ge-6Y for 66991@debbugs.gnu.org; Wed, 08 Nov 2023 03:57:28 -0500 Original-Received: (qmail 91342 invoked by uid 3782); 8 Nov 2023 09:56:43 +0100 Original-Received: from acm.muc.de (p4fe1584b.dip0.t-ipconnect.de [79.225.88.75]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 08 Nov 2023 09:56:42 +0100 Original-Received: (qmail 21734 invoked by uid 1000); 8 Nov 2023 08:56:42 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273974 Archived-At: Hello, Stefan. On Tue, Nov 07, 2023 at 12:38:34 -0500, Stefan Monnier wrote: > > I get a failure in /test/src/comp-tests.log in test > > comp-tests-interactive-form, where the test is expecting > > (interactive) > > but the result of running the test innards is > > (interactive nil) > I'd argue the test should accept either form. > > .. I don't understand why I'm only seeing this test failure now. > Indeed, it's odd. > > Maybe it's a new test. > `git log test/lisp/emacs-lisp/comp-tests.el` suggests there's been no > activity there of late. > > OK. :-) But I think fixing data.c will be easier and cleaner than > > fixing all the tests which might test it. > I wouldn't call it a fix because I don't think the current behavior is > broken, but I see no problem with `interactive-form` replacing > `(interactive)` for `(interactive nil)` when it can do so cheaply. > It may break other (broken) tests, of course. What about replacing (interactive "") with (interactive) too, and documenting this? The doc string says that "Return the interactive form of CMD, or nil ....". But you seem to be arguing that there is no unique _THE_ interactive form. Just three possibilities for _AN_ interactive form. The doc string doesn't make this clear, and needs amending anyway. To fix only the doc string rather than the code too, would double the doc string's size. > Stefan -- Alan Mackenzie (Nuremberg, Germany).