From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#66991: Confusion in interactive-form with commands with bare interactive forms. Date: Tue, 7 Nov 2023 17:10:02 +0000 Message-ID: References: <83wmut1pb1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34219"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, 66991@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 07 18:10:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0PbA-0008fq-SI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Nov 2023 18:10:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0Pay-0006Ie-FL; Tue, 07 Nov 2023 12:10:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0Paq-0006EC-LL for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 12:10:26 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0Paq-0007oe-Cu for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 12:10:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0PbS-0007Qg-5D for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 12:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Nov 2023 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66991 X-GNU-PR-Package: emacs Original-Received: via spool by 66991-submit@debbugs.gnu.org id=B66991.169937704928539 (code B ref 66991); Tue, 07 Nov 2023 17:11:02 +0000 Original-Received: (at 66991) by debbugs.gnu.org; 7 Nov 2023 17:10:49 +0000 Original-Received: from localhost ([127.0.0.1]:43207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0PbF-0007QF-36 for submit@debbugs.gnu.org; Tue, 07 Nov 2023 12:10:49 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:33553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0PbD-0007Pv-5Q for 66991@debbugs.gnu.org; Tue, 07 Nov 2023 12:10:47 -0500 Original-Received: (qmail 11173 invoked by uid 3782); 7 Nov 2023 18:10:02 +0100 Original-Received: from acm.muc.de (p4fe15714.dip0.t-ipconnect.de [79.225.87.20]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 07 Nov 2023 18:10:02 +0100 Original-Received: (qmail 17219 invoked by uid 1000); 7 Nov 2023 17:10:02 -0000 Content-Disposition: inline In-Reply-To: <83wmut1pb1.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273939 Archived-At: Hello, Eli. On Tue, Nov 07, 2023 at 18:49:38 +0200, Eli Zaretskii wrote: > > Date: Tue, 7 Nov 2023 16:38:51 +0000 > > From: Alan Mackenzie > > Consider commands with no arguments, and do interactive-form on them: > > (interactive-form 'x-print-frames-dialog) => (interactive "") # a primitive > > (interactive-form 'universal-argument) => (interactive nil) # a native > > compiled command. > > The result is the same from a byte compiled command. > > Write (defun foo () (interactive)) in *scratch*, and C-M-x to evaluate > > it: > > (interactive-form 'foo) => (interactive). > > That's three different inconsistent ways of expressing "(interactive". > > This is a bug. For consistency's sake, two of them must be incorrect. > Why? Please explain in more positive terms why two out of three must > be bugs, not just in some abstract philosophical terms. I get a failure in /test/src/comp-tests.log in test comp-tests-interactive-form, where the test is expecting (interactive) but the result of running the test innards is (interactive nil) .. I don't understand why I'm only seeing this test failure now. Maybe it's a new test. Also, I think consistency in this sort of thing is a Good Thing. > > I believe the correct one is the last of these, "(interactive)" which is > > after all, what appears in the Lisp sources. The fix should be > > relatively simple, in Finteractive_form in src/data.c > Please wait with implementing a fix until we discuss the issue and > decide whether and how it should be fixed. OK. :-) But I think fixing data.c will be easier and cleaner than fixing all the tests which might test it. > Adding Stefan to the discussion. -- Alan Mackenzie (Nuremberg, Germany).