From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#66912: With `require', the byte compiler reports the wrong file for errors. Date: Fri, 3 Nov 2023 11:32:41 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14778"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier To: 66912@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 03 12:33:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qysQr-0003jq-Cw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Nov 2023 12:33:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qysQa-0007vK-QI; Fri, 03 Nov 2023 07:33:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qysQZ-0007vB-My for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2023 07:33:27 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qysQZ-0000Z6-ES for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2023 07:33:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qysR8-0007eh-KW for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2023 07:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Nov 2023 11:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66912 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169901122629402 (code B ref -1); Fri, 03 Nov 2023 11:34:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Nov 2023 11:33:46 +0000 Original-Received: from localhost ([127.0.0.1]:57103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qysQs-0007eA-Ax for submit@debbugs.gnu.org; Fri, 03 Nov 2023 07:33:46 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:57972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qysQp-0007dw-WB for submit@debbugs.gnu.org; Fri, 03 Nov 2023 07:33:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qysQA-0007sl-S6 for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2023 07:33:02 -0400 Original-Received: from mail.muc.de ([193.149.48.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qysQ6-0000Tl-8J for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2023 07:33:02 -0400 Original-Received: (qmail 22867 invoked by uid 3782); 3 Nov 2023 12:32:42 +0100 Original-Received: from acm.muc.de (p4fe159f2.dip0.t-ipconnect.de [79.225.89.242]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 03 Nov 2023 12:32:41 +0100 Original-Received: (qmail 21474 invoked by uid 1000); 3 Nov 2023 11:32:41 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.3; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273703 Archived-At: Hello, Emacs. When byte compiling file1, and file1 requires file2, should there be an error in file2, it is reported as being in file1, at the requires line. This is entirely unhelpful; the reported position should be that of the error in file2. Things get even more unhelpful if there is a nesting of required files, and the error occurs in a deeply nested file. For an example, create the files ~/test-byte-compile-errors.el: ######################################################################### ;; -*- lexical-binding:t -*- (require 'test-byte-compile-errors-2 "~/test-byte-compile-errors-2") ######################################################################### , and ~/test-byte-compile-errors-2.el: ######################################################################### ;; -*- lexical-binding:t -*- (defvar foo nil) (defun bar () (setq foo)) ; <================== (provide 'test-byte-compile-errors-2) ######################################################################### .. From an Emacs session, do M-x byte-compile-file RET ~/test-byte-compile-errors.el RET .. This will report the error as Compiling file /home/acm/test-byte-compile-errors.el at Fri Nov 3 10:14:40 2023 test-byte-compile-errors.el:2:2: Error: Wrong number of arguments: setq, 1 .. This is not the error location. ######################################################################### Preliminary analysis: The pertinent error information is discarded by one of two condition-cases in the macro displaying-byte-compile-warnings in emacs-lisp/bytecomp.el. If these condition-case's are disabled (for example by spiking the enclosing `if' forms) and the necessary defuns recompiled, there instead appears an error message in the display area. On setting debug-on-error to t and repeating the compilation, one gets a backtrace, which whilst not ideal, is considerably more helpful than the original error message. This appears to be a fundamental problem with condition-case. When an error occurs, the stack gets unwound before the error handlers have a chance to analyse it. -- Alan Mackenzie (Nuremberg, Germany).