From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#65908: 29.1.50; Emacs 29 regresses on macOS Date: Thu, 5 Oct 2023 15:58:54 +0100 Message-ID: References: <83o7hd4n5n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1705"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ccsmile2008@outlook.com, Eli Zaretskii , 65908@debbugs.gnu.org, gregory@heytings.org, stefankangas@gmail.com To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 05 17:00:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qoPpy-0000Hk-Fa for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Oct 2023 17:00:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoPpQ-0003IS-Tn; Thu, 05 Oct 2023 10:59:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoPpM-00039L-Nu for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 10:59:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoPpI-00057A-N0 for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 10:59:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoPpa-0000n9-DA for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 11:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2023 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65908 X-GNU-PR-Package: emacs Original-Received: via spool by 65908-submit@debbugs.gnu.org id=B65908.16965179652970 (code B ref 65908); Thu, 05 Oct 2023 15:00:02 +0000 Original-Received: (at 65908) by debbugs.gnu.org; 5 Oct 2023 14:59:25 +0000 Original-Received: from localhost ([127.0.0.1]:48130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoPoz-0000lq-Cy for submit@debbugs.gnu.org; Thu, 05 Oct 2023 10:59:25 -0400 Original-Received: from dane.soverin.net ([185.233.34.157]:34391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoPou-0000lY-LL for 65908@debbugs.gnu.org; Thu, 05 Oct 2023 10:59:23 -0400 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4S1ZSw21lwz109x; Thu, 5 Oct 2023 14:58:56 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4S1ZSv5QbSzM6; Thu, 5 Oct 2023 14:58:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1696517936; bh=EbhwZSXxO2sW07ts7jUCPd8QrgsGu3IJUtUW0zM2O/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ItDDJ87rgkr35FL3aECbIIumujTGl0ntIRK8c753EvTHpXMM31oMLFOD53toHZtFm vGlIBmAzqX9oTTS8KPB5vh2K3LtWa4V/FKM+Swrs3HUO4jLZ0HmD/26XNZFYx2ovnY WPbzaCKHWu6jj/kYb2I/TxDeN10zW3usuQu/lCF7mqMqIPzeZwJu5lJ3/je4uZ7FnK 1r5SKjZEvvJ9QgAC87Un1UOe4eg3qAjfQLs9dWxkZ+Qr0afCo7gutr4l+iZBKj6pqg rbgLdYF3FdbgoN+vLOAYB8+v35qTspaAGUK5mtDJvcL0ljuozEy9IGHU8O/65FYrHg RVj4d/6DRdamQ== X-Soverin-Authenticated: true Mail-Followup-To: Alan Third , Gerd =?UTF-8?Q?M=C3=B6llmann?= , Eli Zaretskii , gregory@heytings.org, 65908@debbugs.gnu.org, stefankangas@gmail.com, ccsmile2008@outlook.com Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271878 Archived-At: On Thu, Oct 05, 2023 at 04:09:36PM +0200, Gerd Möllmann wrote: > Alan Third writes: > > > Indeed. I'm tempted to say we should revert the change since I now > > suspect I misunderstood how setlocale works when I wrote this and I'm > > not sure it's actually improving anything. > > I hadn't checked this before, but with the patch I sent, the slowness is > indeed gone. What a bloody mess, this stuff :-). Yeah. To answer your question in the other email, I saw the improvement only by removing the setlocale in the "if" statement. Your code has something similar, but it shows the speed improvement anyway, so I'm not sure what's happening differently. I've gone over the NSLocale documentation and it appears it explicitly supports locales like en_DE, but the "UNIX" side of macOS doesn't. I suppose it should be possible to generate your own en_DE locale, but that's a bit much, really. I also prodded at the fallback "system" locale, but it doesn't even provide a locale ID, so it's useless. There's a couple of typos in your commit message. Handle LANG on macOS differntly (bug#bug#65908) ^e ^ -- Alan Third