unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: 65680-done@debbugs.gnu.org
Cc: acm@muc.de
Subject: bug#65680: cl-print-to-string-with-limit erroneously imposes a maximum print-length of 50
Date: Tue, 19 Sep 2023 10:32:19 +0000	[thread overview]
Message-ID: <ZQl4sy5khmGn3TzO@ACM> (raw)
In-Reply-To: <ZPHyaErc3-n5Pa2h@ACM>

The bug has been fixed.

On Fri, Sep 01, 2023 at 14:17:12 +0000, Alan Mackenzie wrote:
> Hello, Emacs.

> In cl-print-to-string-with-limit appears the following binding:

>     (print-length (cond
>                     ((null limit) nil)
>                     ((eq limit t) print-length)
>                     (t (min limit 50))))
>                         ^^^^^^^^^^^^

> ..  This has the effect of ignoring the parameter LIMIT (unless it is
> very small) and instead truncating the printed size to 50.  There is a
> similar mechanism to limit print-level to 8.

> Although the doc string doesn't explicitly say it won't truncate like
> this, it kind of implies that LIMIT is the size it will truncate to.
> This excessive truncation is a bug.

> cl-print-to-string-with-limit is used by backtrace--print-to-string with
> a LIMIT of 5000 to print the first line of a debug buffer.  The error
> message gets rudely truncated at 50 characters with an ellipsis, e.g.:

>     Debugger entered--Lisp error: (error "Invalid call to `edebug-before'.  Is your debug sp...")

> ..  We shouldn't be doing this.  It is irritating to the user.  Correct
> would be to print:

>     Debugger entered--Lisp error: (error "Invalid call to `edebug-before'.  Is your debug spec correct?")

> ..  I propose fixing this bug by removing these limits on print-length and
> print-level in cl-print-to-string-with-limit.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2023-09-19 10:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01 14:17 bug#65680: cl-print-to-string-with-limit erroneously imposes a maximum print-length of 50 Alan Mackenzie
2023-09-19 10:32 ` Alan Mackenzie [this message]
2023-09-21 16:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 16:36   ` Eli Zaretskii
2023-09-21 17:07   ` Alan Mackenzie
2023-09-21 17:51     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 19:22       ` Drew Adams
2023-09-21 20:00         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-21 18:33     ` Eli Zaretskii
     [not found]       ` <ZQ1m766tulSqvuC6@ACM>
     [not found]         ` <83msxe779i.fsf@gnu.org>
     [not found]           ` <ZQ2JVhy-e8NpCJqq@ACM>
     [not found]             ` <837coi74ia.fsf@gnu.org>
     [not found]               ` <jwva5tefif5.fsf-monnier+emacs@gnu.org>
     [not found]                 ` <ZRRGZaRf3WU9z6m_@ACM>
     [not found]                   ` <83v8btywz3.fsf@gnu.org>
2023-09-29 16:49                     ` Alan Mackenzie
2023-09-29 16:53                       ` Eli Zaretskii
2023-10-03  2:11 ` Michael Heerdegen
2023-10-03  9:18   ` Alan Mackenzie
2023-10-03 10:26   ` Alan Mackenzie
2023-10-03 23:35     ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQl4sy5khmGn3TzO@ACM \
    --to=acm@muc.de \
    --cc=65680-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).