From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#59601: 29.0.50; csharp-mode variables missing prefix Date: Sun, 10 Sep 2023 20:53:33 +0000 Message-ID: References: <87lenx4jbo.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29416"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , 59601@debbugs.gnu.org, Theodor Thornhill , acm@muc.de To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 10 22:54:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfRRr-0007SD-Ov for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Sep 2023 22:54:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfRRQ-00068g-Qg; Sun, 10 Sep 2023 16:54:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfRRP-00068Q-FY for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 16:53:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfRRP-000677-6u for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 16:53:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfRRS-0003Rz-6U for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 16:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59601 X-GNU-PR-Package: emacs Original-Received: via spool by 59601-submit@debbugs.gnu.org id=B59601.169437922713240 (code B ref 59601); Sun, 10 Sep 2023 20:54:02 +0000 Original-Received: (at 59601) by debbugs.gnu.org; 10 Sep 2023 20:53:47 +0000 Original-Received: from localhost ([127.0.0.1]:51459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfRRD-0003RU-7k for submit@debbugs.gnu.org; Sun, 10 Sep 2023 16:53:47 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:55917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfRRB-0003RG-Cz for 59601@debbugs.gnu.org; Sun, 10 Sep 2023 16:53:46 -0400 Original-Received: (qmail 77418 invoked by uid 3782); 10 Sep 2023 22:53:35 +0200 Original-Received: from acm.muc.de (p4fe15e8c.dip0.t-ipconnect.de [79.225.94.140]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 10 Sep 2023 22:53:33 +0200 Original-Received: (qmail 8575 invoked by uid 1000); 10 Sep 2023 20:53:33 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270007 Archived-At: Hello, Theodor and Stefan. On Sun, Sep 10, 2023 at 12:30:06 -0700, Stefan Kangas wrote: > Theodor Thornhill writes: > > Stefan Kangas writes: > >> Severity: wishlist > >> Should these variables have the prefix `csharp-'? > >> `codedoc-font-lock-doc-comments' > >> `codedoc-font-lock-keywords' > >> I also see that `codedoc-font-lock-keywords' seems to be unused? > > I believe they need to be like this, for some CC Mode magic reason. See > > `javadoc-font-lock-keywords' and friends. I believe CC Mode picks them > > up and that they should follow that naming convention. I've CC'd Alan > > just to confirm. If you agree Alan then they could be part of > > cc-fonts.el now that csharp-mode is in core. What do you think? > Ping. Alan, do you have any comments? Sorry I missed your (Theodor's) post ~10 months ago. The codedoc variables should _not_ have a csharp- prefix. Conceptually, codedoc is not part of csharp-mode, and could start being used by any CC Mode mode, just as gtkdoc is used by both C and C++ modes. Also, "codedoc" (like "gtkdoc", etc.) is prefixed to "-font-lock-doc-comments" and the result interned to get the function to fontify the doc comments. Thus codedoc-font-lock-doc-comments _will_ be getting used. So, yes, the naming convention is essential to the working of CC Mode's doc comments. Whether it would be the Right Thing to add codedoc to CC Mode itself, I'm not sure. doxygen was added quite recently, but that is genuinely a language independent format. I'm a little worried about getting some coupling between, say, csharp-mode and CC Mode where there wasn't any before. -- Alan Mackenzie (Nuremberg, Germany).