From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Sat, 12 Aug 2023 10:41:24 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28399"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65051@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 12 12:42:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUm4P-0007D5-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Aug 2023 12:42:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUm4J-0000fH-VM; Sat, 12 Aug 2023 06:42:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUm4I-0000f0-5R for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 06:42:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUm4H-0005Ou-Th for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 06:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUm4H-0005O5-PL for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 06:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2023 10:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.169183689320618 (code B ref 65051); Sat, 12 Aug 2023 10:42:01 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 12 Aug 2023 10:41:33 +0000 Original-Received: from localhost ([127.0.0.1]:48795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUm3p-0005MU-6T for submit@debbugs.gnu.org; Sat, 12 Aug 2023 06:41:33 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:47528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUm3n-0005M5-HV for 65051@debbugs.gnu.org; Sat, 12 Aug 2023 06:41:32 -0400 Original-Received: (qmail 32769 invoked by uid 3782); 12 Aug 2023 12:41:25 +0200 Original-Received: from acm.muc.de (p4fe1539a.dip0.t-ipconnect.de [79.225.83.154]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 12 Aug 2023 12:41:24 +0200 Original-Received: (qmail 9538 invoked by uid 1000); 12 Aug 2023 10:41:24 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267298 Archived-At: Hello, Stefan. On Sat, Aug 12, 2023 at 01:36:08 -0400, Stefan Monnier wrote: [ .... ] > ..... (BTW, why we do handle SWP specially in `time-convert`?). That was this patch: commit 343482d641511b54aa0444791770b4ea70d27cc7 Author: Paul Eggert Date: Wed Jun 15 23:08:03 2022 -0500 Streamline time decoding and conversion * src/lisp.h (lisp_h_BASE2_EQ, BASE2_EQ): New macros and functions. * src/timefns.c (tzlookup, Fdecode_time): Use them. (Ftime_convert): Convert to symbol once, instead of many times. <===== .. form, if a SWP, gets replaced by its bare symbol, so that the following comparisons can be done by BASE_EQ rather than EQ. It's an optimisation, though I can't really see why it's worthwhile. If you remove that SWP handling, as you are proposing, you'll need to set these BASE_EQ's back to EQ's, too. > Stefan [ .... ] > diff --git a/src/timefns.c b/src/timefns.c > index 151f5b482a3..7e030da3fcd 100644 > --- a/src/timefns.c > +++ b/src/timefns.c > @@ -1767,8 +1767,6 @@ DEFUN ("time-convert", Ftime_convert, Stime_convert, 1, 2, 0, > enum timeform input_form = decode_lisp_time (time, false, &t, 0); > if (NILP (form)) > form = current_time_list ? Qlist : Qt; > - if (symbols_with_pos_enabled && SYMBOL_WITH_POS_P (form)) > - form = SYMBOL_WITH_POS_SYM (form); > if (BASE_EQ (form, Qlist)) > return ticks_hz_list4 (t.ticks, t.hz); > if (BASE_EQ (form, Qinteger)) -- Alan Mackenzie (Nuremberg, Germany).