From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Fri, 11 Aug 2023 14:04:59 +0000 Message-ID: References: <6a81c696-4e6a-ac24-6c66-7e2b541ed67a@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26025"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65051@debbugs.gnu.org, Stefan Monnier To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 11 16:06:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUSmZ-0006cx-86 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Aug 2023 16:06:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUSmE-0007V5-0J; Fri, 11 Aug 2023 10:06:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUSmA-0007Tx-Vm for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 10:06:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUSmA-0006jz-JG for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 10:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUSmA-0000V6-5b for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2023 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.16917627111865 (code B ref 65051); Fri, 11 Aug 2023 14:06:02 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 11 Aug 2023 14:05:11 +0000 Original-Received: from localhost ([127.0.0.1]:47235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUSlL-0000U1-F7 for submit@debbugs.gnu.org; Fri, 11 Aug 2023 10:05:11 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:11732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUSlH-0000TM-2R for 65051@debbugs.gnu.org; Fri, 11 Aug 2023 10:05:10 -0400 Original-Received: (qmail 11545 invoked by uid 3782); 11 Aug 2023 16:05:00 +0200 Original-Received: from acm.muc.de (p4fe151b9.dip0.t-ipconnect.de [79.225.81.185]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 11 Aug 2023 16:04:59 +0200 Original-Received: (qmail 7652 invoked by uid 1000); 11 Aug 2023 14:04:59 -0000 Content-Disposition: inline In-Reply-To: <6a81c696-4e6a-ac24-6c66-7e2b541ed67a@gutov.dev> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267213 Archived-At: Hello, Dmitry. On Fri, Aug 11, 2023 at 16:19:47 +0300, Dmitry Gutov wrote: > Hi again, Alan, > On 11/08/2023 15:05, Alan Mackenzie wrote: > >>> I think it was possibly a design error to have text > >>> properties conceptually as a part of a string/buffer rather than > >>> something associated with it, like an overlay. The fact that equal > >>> ignores these properties supports this view. > >> We needed a reference to access the properties from. Overlays are > >> different because they attach to a buffer. There is nothing else to > >> attach to when you have a string value. > > This is arbitrary; overlays _could_ have been made attachable to > > strings, in which case text properties need not have been. That would > > have prevented all the heart searching when considering equal with > > strings. > Then we would have some "metadata" that's part of the value, and some > that is not part of the value. How would we look those up, though? > Through a global registry? > equal-including-properties is useful enough, by the way. In the tests, > at least. Yes. > >> Which seems very similar to the situation with symbols, I think. > > There are practical differences. Having symbols with position simply > > handled as their bare symbols would slow down Emacs quite a lot. That's > > why we have symbols-with-pos-enabled. But you know that. > Does the current impl of 'equal' create worse performance as well? That > would be a good argument to change it. Yes, but unmeasurably so. The current implementation has two comparisons, quite complicated, where only one simple one is needed, for the typical use-case. > > Currently, the working of s-w-p-enabled is inconsistent, and > > should be fixed, which is what this bug is about. > Inconsistent with what? With its definition: when s-w-p-enabled is non-nil, SWPs are handled specially. When it's nil, they're not (or, at least, shouldn't be). > If we're talking about the relation between EQUAL and EQ, objects that > are EQ have to be EQUAL, but those that are EQUAL don't have to be EQ. I wasn't talking about that relationship, no, but there is no danger to it in fixing the current bug (or, indeed, in leaving it unfixed). > Anyway, I'd like to offer a question from a different perspective: > should two symbols-with-positions where the positions are different but > the symbol is the same, be equal between each other? Yes, when and only when symbols-with-pos-enabled is non-nil. > If yes (which is my reading of fns.c:2755), then it makes sense for > them to be equal-able to symbols without positions as well. Again, this should be the case when s-w-p-enabled is non-nil and only then. -- Alan Mackenzie (Nuremberg, Germany).