From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Fri, 11 Aug 2023 12:05:34 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7756"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65051@debbugs.gnu.org, Stefan Monnier To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 11 14:06:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUQuH-0001t1-9V for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Aug 2023 14:06:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUQu4-0003fs-Or; Fri, 11 Aug 2023 08:06:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUQu2-0003fe-OQ for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 08:06:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUQu2-0002gS-9q for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 08:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUQu1-0005Am-Of for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 08:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2023 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.169175554819864 (code B ref 65051); Fri, 11 Aug 2023 12:06:01 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 11 Aug 2023 12:05:48 +0000 Original-Received: from localhost ([127.0.0.1]:45108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUQto-0005AJ-3D for submit@debbugs.gnu.org; Fri, 11 Aug 2023 08:05:48 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:63699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUQti-00059y-BN for 65051@debbugs.gnu.org; Fri, 11 Aug 2023 08:05:46 -0400 Original-Received: (qmail 75375 invoked by uid 3782); 11 Aug 2023 14:05:35 +0200 Original-Received: from acm.muc.de (p4fe151b9.dip0.t-ipconnect.de [79.225.81.185]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 11 Aug 2023 14:05:35 +0200 Original-Received: (qmail 6548 invoked by uid 1000); 11 Aug 2023 12:05:34 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267210 Archived-At: Hello, Dmitry. On Fri, Aug 11, 2023 at 14:18:15 +0300, Dmitry Gutov wrote: > On 11/08/2023 13:42, Alan Mackenzie wrote: > > On Fri, Aug 11, 2023 at 03:51:09 +0300, Dmitry Gutov wrote: > >> On 08/08/2023 18:33, Alan Mackenzie wrote: > >>>> So I'm still wondering why you think it's a bug. > >>> Because it violates the definition and basic understanding of equal. > >>> It's a special case when no special case is needed. > >> Does 'equal'-ity of strings with and without text properties (or with > >> different text properties) violate these as well? > > Maybe, maybe not. It depends on whether you consider the text > > properties on a string (or buffer portion) an essential part of the > > string or not. > ...or, like, a metadata attached to a value. Which is an approach to > have its benefits as well, seeing how we've been living with it for many > years. > > I think it was possibly a design error to have text > > properties conceptually as a part of a string/buffer rather than > > something associated with it, like an overlay. The fact that equal > > ignores these properties supports this view. > We needed a reference to access the properties from. Overlays are > different because they attach to a buffer. There is nothing else to > attach to when you have a string value. This is arbitrary; overlays _could_ have been made attachable to strings, in which case text properties need not have been. That would have prevented all the heart searching when considering equal with strings. > Which seems very similar to the situation with symbols, I think. There are practical differences. Having symbols with position simply handled as their bare symbols would slow down Emacs quite a lot. That's why we have symbols-with-pos-enabled. But you know that. Currently, the working of s-w-p-enabled is inconsistent, and should be fixed, which is what this bug is about. -- Alan Mackenzie (Nuremberg, Germany).