bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled.

[Alan Mackenzie <acm@muc.de>]

Hello, Stefan.

On Wed, Aug 09, 2023 at 23:28:53 -0400, Stefan Monnier wrote:
> >> >> Could you explain why you think it's a bug?
> >> > When symbols-with-pos-enabled is non-nil, the two arguments to that
> >> > equal call are equal.  That is the point of s-w-p-e.
> >> AFAIK the point of the `symbols-with-pos-enabled` is to try and keep the
> >> performance impact of sympos under control, and that matters only for
> >> `eq`, so I don't think there's a strong reason here for `equal` to pay
> >> attention to it.
> > Which is like saying you're happy for it to be undefined.

> Not quite.  I'm saying that as far as technical reasons go, I can't see
> any reason why `equal` needs to pay attention to
> `symbols-with-pos-enabled`.

I can.

> IOW affecting the behavior of `equal` is *not* part of "the point of
> s-w-p-e".

Which is precisely why I want to correct the behaviour of equal with
SWPs.

> > In the code at the moment, the result of `equal' on symbols with
> > position is undefined, i.e. it returns a random value.

> In which sense?

In the sense it wasn't deliberately coded.  It's just a random value
resulting from the code for other scenarios.

> AFAICT it returns non-nil iff the underlying bare symbols are `eq`.
> That does not sound "random" at all to me.
> What am I missing?

That equal is different from eq.  The definition of eq (more or less) is
"identical objects".  The definition of equal (more or less) is "same
structure with same components".

> >> So I'm still wondering why you think it's a bug.
> > Because it violates the definition and basic understanding of equal.

> Could you expand on that, e.g. explaining which part of your
> understanding of "the definition and basic understanding of equal"
> it violates?

See my previous paragraph of this post.  You're proposing that the
position elements of SWPs should be ignored in equal.  I don't see any
good reason for this.

> > It's a special case when no special case is needed.

> Making `equal` depend on a global variable is also introducing
> a special case.

I know you don't like symbols-with-pos-enabled, but it's there.  It
implements, by its very nature, special cases when it's non-nil.  You
want to extend those special cases to the behaviour when it's nil.

> IOW, all choices suck in one way or another.

Not really.

> I think we need more practical and concrete reasons to prefer one over
> another.  Philosophical arguments seem rather weak here.

The consistency of Emacs's basic functions seems very important to me,
and it's likely very important to other people, too.  You seem to be
dismissing it as unimportant.

> >> AFAICT whether sympos should be `equal` to others and/or to bare symbols
> >> is something we pretty much get to choose freely based on convenience:
> > No we don't.  They have to be chosen to be as consistent as possible
> > with the rest of Emacs.

> `equal` is not self-consistent.  It compares hash-tables like `eq` but
> looks inside vectors.  It ignores strings' properties.  The list goes on
> and on.

I said "as consistent as possible", not "absolutely consistent".  There
is no need to make that list of inconsistencies any bigger.

> >> either the current behavior or the one you now advocate are perfectly
> >> acceptable and not bugs.
> > The current behaviour is a bug.

> Hmm... This subthread is supposed to answer my question about why you
> think it's a bug.  So just re-stating it is not very helpful.
> Please try and articulate more precisely *why* you think it's the case.
> Is it a gut-feeling?

I've outlined several times why it's a bug.  Please re-read my posts in
this thread.

> > It was me that coded up that amendment to equal, and I can remember
> > simply not taking into account the scenario we're talking about.

> Which scenario?

<sigh> Comparing two arguments using equal, at least one of which is a
symbol with position, when symbols-with-pos-enabled is nil.

> >> As I said elsewhere, I'm not sure which choice is best, but at least we
> >> have some experience with the current choice ....
> > I rather doubt that.  When have SWPs, when symbols-with-pos-enabled is
> > nil, been tested by equal, apart from in tests, maybe?

> We don't know, admittedly, but we do know that if/when it has happened,
> it hasn't caused any problem so far.

Just like binding symbols-with-position-enabled in
internal-macroexpand-for-load didn't cause any problems, until it did
(bug #65017).

> >> .... and I haven't seen any clear problem with it yet, so I'd tend to
> >> lean towards keeping the current behavior.
> > I'm wondering why you're making such a big thing out of it.  It's a
> > small change which will increase consistency and predictability in
> > Emacs in a small way, without any negative effects.

> I don't see either of the two options as being more consistent or
> more predictable.

So why are you making such a big thing out of it?  I see quite clearly
which of these options is correct.  Why won't you respect my superior
insight into the matter?

> You can see symbols' positions as being similar to strings'
> properties, which `equal` gleefully ignores.

> I think the main reasons I'm rather opposed are:

> - I don't like making `equal` depend on a global variable.

You prefer to make the effect of equal inconsistent.

>   It makes it impure, and will invalidate existing optimizations,
>   exactly like we've just witnessed for `eq`.

Which optimisations are you talking about here?  Just how is equal
optimised?  The function internal_equal will be called in all cases,
apart from, perhaps, when called with identical arguments.

> - I consider `symbols-with-pos-enabled` to be a wart, so I'd rather try
>   and minimize its use as much as possible.

Why do you want to minimise its use, wart or not?  Do you not care about
its consistency?

> >> What would be the concrete advantages of the new behavior compared to
> >> the current one?
> > There are no "concrete" advantages, aside from an insignificant increase
> > in speed for Emacs when not byte compiling.  The code and the
> > documentation currently don't match.  Fixing the code, by removing a
> > special case, is easier and more satisfying than documenting that
> > special case in the Elisp manual.

> Then, I'd vote to fix the doc rather than the code.

Write a proposed patch to the doc, then, and post it in this thread.

At this stage, I feel I must point out that arguing with you on this
mailing list about this point has taken up more time that fixing the
code and documentation did.  That is not a good thing.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).