From: Alan Third <alan@idiocy.org>
To: David Ponce <da_vid@orange.fr>
Cc: Eli Zaretskii <eliz@gnu.org>, 64908@debbugs.gnu.org
Subject: bug#64908: 29.1; svg parse failure
Date: Sat, 5 Aug 2023 18:39:10 +0100 [thread overview]
Message-ID: <ZM6JPk57AR50ea/u@idiocy.org> (raw)
In-Reply-To: <6fa9c98e-e7ce-33de-c21d-bb36ab8687da@orange.fr>
On Sat, Aug 05, 2023 at 07:37:01PM +0200, David Ponce wrote:
> On 05/08/2023 18:31, Alan Third wrote:
> > On Sat, Aug 05, 2023 at 06:24:43PM +0200, David Ponce wrote:
> > >
> > > Background is white by default.
> >
> > Thanks.
> >
> > > Just before call rsvg_handle_get_geometry_for_layer (line 11412 in image.c):
> > >
> > > (gdb) print zero_rect
> > > $1 = {x = 6.9533474147268633e-310, y = 2.4608421688060808e-319, width = 5.8283471538673388e-315, height = 9.8813129168249309e-323}
> > > (gdb) print viewbox
> > > $2 = {x = 6.9533558057749482e-310, y = 6.9533473517748961e-310, width = 1.4821969375237396e-323, height = 3.0586981611317814e-317}
> > > (gdb) print out_logical_rect
> > > $3 = {x = 1.2476920383715837e-316, y = 0, width = 0, height = 3.3675983782902914e-317}
> > >
> > > Just after:
> > >
> > > (gdb) print zero_rect
> > > $4 = {x = 6.9533474147268633e-310, y = 2.4608421688060808e-319, width = 5.8283471538673388e-315, height = 9.8813129168249309e-323}
> > > (gdb) print viewbox
> > > $5 = {x = 0, y = 0, width = 0, height = 0}
> > > (gdb) print out_logical_rect
> > > $6 = {x = 0, y = 0, width = 0, height = 0}
> > > (gdb) print $eax
> > > $7 = 1
> >
> > Yeah, I see what's going on.
> >
> > I was under the impression a new struct should always be set to all
> > zeroes, but evidently not.
> >
> > Are you getting any build warnings about it being uninitialised?
> >
> > Anyway, 3rd go at the patch attached.
>
> Thanks
>
> I just tried patch V3, and the result is the same:
> insert-image produces the same black square of 22x22 pixels.
Can you try changing the initialisation of zero_rect to {0, 0, 10,
10}?
I remember a lot of trial and error with this originally, and it looks
like they may have changed how it works.
--
Alan Third
next prev parent reply other threads:[~2023-08-05 17:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 1:10 bug#64908: 29.1; svg parse failure Daniel Vianna
2023-07-28 6:05 ` Eli Zaretskii
[not found] ` <CAMLJ+NHO38NYGPctAj9MmMwy4tz8aSqHgLDWQhQaDm7FUP7Yqw@mail.gmail.com>
2023-07-28 11:00 ` Eli Zaretskii
2023-07-28 12:48 ` Visuwesh
2023-08-03 8:11 ` Eli Zaretskii
2023-08-03 19:16 ` David Ponce
2023-08-04 5:23 ` Eli Zaretskii
2023-08-04 7:55 ` David Ponce
2023-08-04 10:26 ` Eli Zaretskii
2023-08-04 16:23 ` David Ponce
2023-08-04 18:32 ` Alan Third
2023-08-04 19:08 ` Eli Zaretskii
2023-08-04 21:08 ` David Ponce
2023-08-05 8:30 ` David Ponce
2023-08-05 9:58 ` Alan Third
2023-08-05 10:07 ` Eli Zaretskii
2023-08-05 10:24 ` Alan Third
2023-08-05 10:41 ` Eli Zaretskii
2023-08-05 12:32 ` David Ponce
2023-08-05 15:14 ` Alan Third
2023-08-05 15:53 ` David Ponce
2023-08-05 16:02 ` Alan Third
2023-08-05 16:24 ` David Ponce
2023-08-05 16:31 ` Alan Third
2023-08-05 17:37 ` David Ponce
2023-08-05 17:39 ` Alan Third [this message]
2023-08-05 18:00 ` David Ponce
2023-08-05 18:31 ` Alan Third
2023-08-05 20:04 ` David Ponce
2023-08-08 13:58 ` David Ponce
2023-08-08 21:18 ` Alan Third
2023-08-08 22:22 ` David Ponce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZM6JPk57AR50ea/u@idiocy.org \
--to=alan@idiocy.org \
--cc=64908@debbugs.gnu.org \
--cc=da_vid@orange.fr \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).