From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Fri, 4 Aug 2023 17:06:10 +0000 Message-ID: References: <83leeqvpx8.fsf@gnu.org> <83h6pevnd0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65051@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 19:07:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRyGh-0006fb-Tx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 19:07:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRyGX-0000d1-4b; Fri, 04 Aug 2023 13:07:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRyGU-0000ZV-9b for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 13:07:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRyGU-0006fr-0x for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 13:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRyGT-0008HP-SO for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 13:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.169116877931763 (code B ref 65051); Fri, 04 Aug 2023 17:07:01 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 4 Aug 2023 17:06:19 +0000 Original-Received: from localhost ([127.0.0.1]:54671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRyFn-0008GF-6c for submit@debbugs.gnu.org; Fri, 04 Aug 2023 13:06:19 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:60448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRyFk-0008G1-A6 for 65051@debbugs.gnu.org; Fri, 04 Aug 2023 13:06:17 -0400 Original-Received: (qmail 21481 invoked by uid 3782); 4 Aug 2023 19:06:10 +0200 Original-Received: from acm.muc.de (pd953a874.dip0.t-ipconnect.de [217.83.168.116]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 04 Aug 2023 19:06:10 +0200 Original-Received: (qmail 28134 invoked by uid 1000); 4 Aug 2023 17:06:10 -0000 Content-Disposition: inline In-Reply-To: <83h6pevnd0.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266697 Archived-At: Hello, Eli. On Fri, Aug 04, 2023 at 18:27:55 +0300, Eli Zaretskii wrote: > > Date: Fri, 4 Aug 2023 14:59:58 +0000 > > Cc: 65051@debbugs.gnu.org, acm@muc.de > > From: Alan Mackenzie > > > What will happen to the comparison in internal_equal when > > > symbols_with_pos_enabled is zero and the two objects have different > > > positions, or one has a position, the other doesn't? > > In these cases, equal will return nil. This is correct. > It is? I thought when symbols with position are disabled, symbols > that are 'eq', but have different positions, should compare equal? > Why not? With symbols-with-pos-enabled nil, # is not EQ to #. Neither are these two objects `equal'. This is because the special, time consuming processing which makes them EQ or `equal' is enabled by that variable being bound to non-nil. That's the theory. In practice, the handling in internal_equal forgot to check for symbols-with-pos-enabled. That's what I want to fix, now. > > In the other case, when two symbols with position have the same base > > symbol and the same position, yet aren't identical, this will also return > > nil, which is incorrect. > How can they be not identical if the symbols and the positions are the > same? Or maybe I don't understand what you mean by "base symbol"? By "base symbol" I mean 'foo in #. By "identical" I meant that the two Lisp_Objects would have the same hex value (i.e. be EQ without symbols-with-pos-enabled), as contrasted to two distinct Lisp_Objects with the same base symbol, and the same position, i.e. should be `equal'. The way internal_equal is coded, only certain subtypes of Lisp_vectorlike have their innards compared. The other subtypes are simply assumed not `equal'. PVEC_SYMBOL_WITH_POS currently isn't among these subtypes, though this could be changed easily enough. > > > And which branch are you proposing this change for? > > master. It doesn't seem important enough for the release branch. > OK. -- Alan Mackenzie (Nuremberg, Germany).