From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Fri, 4 Aug 2023 14:00:29 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9978"; mail-complaints-to="usenet@ciao.gmane.io" To: 65051@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 16:01:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRvMs-0002TI-EL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 16:01:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRvMX-0004bM-Gq; Fri, 04 Aug 2023 10:01:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRvMU-0004Wy-V2 for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 10:01:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRvMU-0001tX-MR for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 10:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRvMU-0008Q4-7X for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 10:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65051 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169115764532326 (code B ref -1); Fri, 04 Aug 2023 14:01:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Aug 2023 14:00:45 +0000 Original-Received: from localhost ([127.0.0.1]:54452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRvMC-0008PK-Vh for submit@debbugs.gnu.org; Fri, 04 Aug 2023 10:00:45 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:45002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRvMB-0008P3-8s for submit@debbugs.gnu.org; Fri, 04 Aug 2023 10:00:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRvM3-00048x-PV for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 10:00:35 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRvM1-0001j8-H2 for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 10:00:35 -0400 Original-Received: (qmail 5183 invoked by uid 3782); 4 Aug 2023 16:00:29 +0200 Original-Received: from acm.muc.de (pd953a874.dip0.t-ipconnect.de [217.83.168.116]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 04 Aug 2023 16:00:29 +0200 Original-Received: (qmail 1070 invoked by uid 1000); 4 Aug 2023 14:00:29 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266673 Archived-At: Hello, Emacs. The code in question is in internal_equal (src/fns.c) ~37 lines from its start. We have: if (SYMBOL_WITH_POS_P (o1)) o1 = SYMBOL_WITH_POS_SYM (o1); if (SYMBOL_WITH_POS_P (o2)) o2 = SYMBOL_WITH_POS_SYM (o2); at the top level of the function. Thus (equal 'foo #) will return non-nil, regardless of the setting of symbols-with-pos-enabled. It should return non-nil only when that flag variable is non-nil. This is a bug. ######################################################################### A simple fix is: diff --git a/src/fns.c b/src/fns.c index bfd19e8c8f2..b1f0c4ecdd6 100644 --- a/src/fns.c +++ b/src/fns.c @@ -2773,10 +2773,13 @@ internal_equal (Lisp_Object o1, Lisp_Object o2, enum equal_kind equal_kind, /* A symbol with position compares the contained symbol, and is `equal' to the corresponding ordinary symbol. */ - if (SYMBOL_WITH_POS_P (o1)) - o1 = SYMBOL_WITH_POS_SYM (o1); - if (SYMBOL_WITH_POS_P (o2)) - o2 = SYMBOL_WITH_POS_SYM (o2); + if (symbols_with_pos_enabled) + { + if (SYMBOL_WITH_POS_P (o1)) + o1 = SYMBOL_WITH_POS_SYM (o1); + if (SYMBOL_WITH_POS_P (o2)) + o2 = SYMBOL_WITH_POS_SYM (o2); + } if (BASE_EQ (o1, o2)) return true; -- Alan Mackenzie (Nuremberg, Germany).