unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, Andrea Corallo <acorallo@gnu.org>,
	64642-done@debbugs.gnu.org
Subject: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions.
Date: Wed, 19 Jul 2023 11:31:14 +0000	[thread overview]
Message-ID: <ZLfJgueJwM9m21eA@ACM> (raw)
In-Reply-To: <83v8ei7c9p.fsf@gnu.org>

Hello, Eli.

On Mon, Jul 17, 2023 at 19:06:58 +0300, Eli Zaretskii wrote:
> > From: Andrea Corallo <acorallo@gnu.org>
> > Cc: Eli Zaretskii <eliz@gnu.org>,  64642@debbugs.gnu.org
> > Date: Mon, 17 Jul 2023 09:42:31 -0400

> > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is
> > >> so simple that will surprise me.

> > > Here is a fix.  Its simplicity probably doesn't surprise you (Eli), but
> > > the change is entirely within one function, and a lot of the patch is
> > > just whitespace changes.

> > > There are no problems running make bootstrap or make check with patch in
> > > place.  It also solves the bug; unless there are good reasons dynamically
> > > bound functions weren't handled.  Andrea?

> > Hi Alan,

> > the fix LGTM thanks for the patch, I think we only need to add a test as
> > well to exercise this code, something like the "free-fun" test in
> > comp-tests.el.

> Alan, when the patch is ready, please install on master.

DONE.  I'm closing the bug with this post.

> Thanks.

-- 
Alan Mackenzie (Nuremberg, Germany).





      parent reply	other threads:[~2023-07-19 11:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15  9:38 bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions Alan Mackenzie
2023-07-15  9:53 ` Eli Zaretskii
2023-07-15 15:17   ` Alan Mackenzie
2023-07-17 13:42     ` Andrea Corallo
2023-07-17 16:06       ` Eli Zaretskii
2023-07-17 17:43         ` Alan Mackenzie
2023-07-19 11:31         ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLfJgueJwM9m21eA@ACM \
    --to=acm@muc.de \
    --cc=64642-done@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).